Last modified: 2014-11-18 13:52:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71515, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69515 - Cannot copy text when dm.surface.enabled === false
Cannot copy text when dm.surface.enabled === false
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Ed Sanders
:
: 69516 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-14 00:32 UTC by Ryan Wold
Modified: 2014-11-18 13:52 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Wold 2014-08-14 00:32:08 UTC
When disabling an Editor's .target.surface (by calling .disable()), the text is no longer editable, which is great.  However, the text in the disabled Editor cannot be copied and pasted.  It does not appear to make it to the clipboard. 

Desired behavior is that the text can be be copied even when the editor is disabled.  Or perhaps there could be a setting/option around that.



We traced this to ve.dm.Surface.prototype.changeInternal, where it returns immediately if the surface is disabled.

if ( !this.enabled ) {
  return;
}

I found this here: https://doc.wikimedia.org/VisualEditor/master/source/ve.dm.Surface.html#ve-dm-Surface-method-changeInternal


I'm using OSX Mavericks and Google Chrome Version 36.0.1985.125.

Thanks!

- Ryan Wold
  ryan.wold@neo.com
Comment 1 Ryan Wold 2014-08-14 00:34:15 UTC
*** Bug 69516 has been marked as a duplicate of this bug. ***
Comment 2 Ed Sanders 2014-11-18 13:52:51 UTC
The surface model also tracks selections so disabling the surface model would also disable any meaningful copy/paste functionality. dm.Surface#disable is not really intended for putting the surface into a useful read-only mode. What exactly are you trying to achieve?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links