Last modified: 2014-08-15 14:47:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71542, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69542 - EntityIdValues displayed as UnDeserializableValues
EntityIdValues displayed as UnDeserializableValues
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Immediate critical (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-14 14:08 UTC by Aude
Modified: 2014-08-15 14:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-08-14 14:08:28 UTC
EntityIdValues are being displayed in the entity view as UnDeserializableValues.

They appear to be UnDeserializableValue when generating ParserOutput in EntityView.

I have $wgWBRepoSettings['internalEntitySerializerClass'] = 'Wikibase\Lib\Serializers\LegacyInternalEntitySerializer';
Comment 1 Gerrit Notification Bot 2014-08-15 12:39:18 UTC
Change 154259 had a related patch set uploaded by Aude:
Re-add $evilDataValueMap global, still used in DataModel 0.8.2

https://gerrit.wikimedia.org/r/154259
Comment 2 Gerrit Notification Bot 2014-08-15 12:42:40 UTC
Change 154260 had a related patch set uploaded by Aude:
Re-add $evilDataValueMap global, still used in DataModel 0.8.2

https://gerrit.wikimedia.org/r/154260
Comment 3 Jeroen De Dauw 2014-08-15 13:59:03 UTC
The old serialization code does not need this global. It's needed by the old deserilaization code. So this is not affected by internalEntitySerializerClass.
Comment 4 Jeroen De Dauw 2014-08-15 14:02:14 UTC
Ok, we figured out the code that depends on the global is invoked by the unstubbing code in DataModel itself, so we cannot get rid of the global untill we switch to DataModel 1.0.
Comment 5 Gerrit Notification Bot 2014-08-15 14:04:58 UTC
Change 154260 merged by jenkins-bot:
Re-add $evilDataValueMap global, still used in DataModel 0.8.2

https://gerrit.wikimedia.org/r/154260
Comment 6 Gerrit Notification Bot 2014-08-15 14:43:45 UTC
Change 154259 merged by jenkins-bot:
Re-add $evilDataValueMap global, still used in DataModel 0.8.2

https://gerrit.wikimedia.org/r/154259

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links