Last modified: 2014-08-26 03:37:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71565, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69565 - BadMethodCallException with "Call to a member function getId" in SpecialCentralLogin.php on Beta Labs
BadMethodCallException with "Call to a member function getId" in SpecialCentr...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
master
All All
: Highest major (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-14 20:19 UTC by Matthew Flaschen
Modified: 2014-08-26 03:37 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-08-14 20:19:16 UTC
Upon going to Special:UserLogin on English Wikipedia on Beta Labs (http://en.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin), I got redirected to Special:CentralLogin/complete (with token).  However, it then threw an exception:

---
Unexpected non-MediaWiki exception encountered, of type "BadMethodCallException"
[31c07ff4] /wiki/Special:CentralLogin/complete?token=201d1e72216aa80eef3f599b689e7bdc Exception from line 166 of /srv/common-local/php-master/extensions/CentralAuth/specials/SpecialCentralLogin.php: Call to a member function getId() on a non-object (boolean)
Backtrace:
#0 /srv/common-local/php-master/extensions/CentralAuth/specials/SpecialCentralLogin.php(33): SpecialCentralLogin->doLoginComplete(string)
#1 /srv/common-local/php-master/includes/specialpage/SpecialPage.php(357): SpecialCentralLogin->execute(string)
#2 /srv/common-local/php-master/includes/specialpage/SpecialPageFactory.php(516): SpecialPage->run(string)
#3 /srv/common-local/php-master/includes/MediaWiki.php(300): SpecialPageFactory::executePath(Title, RequestContext)
#4 /srv/common-local/php-master/includes/MediaWiki.php(609): MediaWiki->performRequest()
#5 /srv/common-local/php-master/includes/MediaWiki.php(460): MediaWiki->main()
#6 /srv/common-local/php-master/index.php(46): MediaWiki->run()
#7 /srv/common-local/w/index.php(3): include(string)
#8 {main}
---
Comment 1 Andre Klapper 2014-08-15 12:11:03 UTC
Confirming.
No idea if this is specific to BetaLabs or a general issue in CentralAuth, hence tentatively setting highest prio and CC'ing Greg and Chris.
Comment 2 Greg Grossmeier 2014-08-15 15:11:39 UTC
Chris S/Kunal: Any ideas?
Comment 3 Kunal Mehta (Legoktm) 2014-08-15 16:10:23 UTC
We ran into this on testwiki (I2488e1fd3109ce66c2cb42d9afc78097f2b7313d) which Reedy backported and deployed so now it's throwing a MWException instead of a fatal error. I'm not sure whether it is supposed to be redirecting the user in the first place though...
Comment 4 Chris Steipp 2014-08-15 17:00:44 UTC
Are we running low on session/cache storage (I'm not sure if it's redis or memcached backed in beta)?

I can login fine there-- I'm assuming this is intermittent?
Comment 5 Andre Klapper 2014-08-15 21:08:17 UTC
(In reply to Chris Steipp from comment #4)
> I can login fine there-- I'm assuming this is intermittent?

I tried now ~15 times (bypassing Firefox' browser cache) and it showed the exception every single time.
Comment 6 Chris Steipp 2014-08-15 21:35:04 UTC
Hmm. Browser specific bug?

I can login with Chrome without any problem. Firefox I don't get this exception, instead I (repeatably) get:

    Function: EchoTargetPageMapper::fetchByUserPageId
    Error: 1146 Table 'enwiki.echo_target_page' doesn't exist (10.68.17.94)
Comment 7 Chris Steipp 2014-08-15 21:38:30 UTC
(In reply to Chris Steipp from comment #6)
> Hmm. Browser specific bug?
> 
> I can login with Chrome without any problem. Firefox I don't get this
> exception, instead I (repeatably) get:
> 
>     Function: EchoTargetPageMapper::fetchByUserPageId
>     Error: 1146 Table 'enwiki.echo_target_page' doesn't exist (10.68.17.94)

Scratch that. I get this ^^^^ error for every single article page when I'm logged in, with both browsers now. After Echo fixes their issue, I'll keep working on this bug.
Comment 8 Andre Klapper 2014-08-17 10:28:13 UTC
(In reply to Chris Steipp from comment #7)
> (In reply to Chris Steipp from comment #6)
> >     Function: EchoTargetPageMapper::fetchByUserPageId
> >     Error: 1146 Table 'enwiki.echo_target_page' doesn't exist (10.68.17.94)
> 
> I get this ^^^^ error for every single article page when I'm logged in, with
> both browsers now. After Echo fixes their issue, I'll keep working on this bug

Has the Echo team been notified (CC"ing some more folks now)? 
Is there a dedicated bug report about that issue?
Comment 9 Andre Klapper 2014-08-18 08:46:41 UTC
(In reply to Andre Klapper from comment #8)
> Has the Echo team been notified (CC"ing some more folks now)? 
> Is there a dedicated bug report about that issue?

Ah, might be bug 69590
Comment 10 Greg Grossmeier 2014-08-25 15:54:28 UTC
(In reply to Andre Klapper from comment #9)
> (In reply to Andre Klapper from comment #8)
> > Has the Echo team been notified (CC"ing some more folks now)? 
> > Is there a dedicated bug report about that issue?
> 
> Ah, might be bug 69590

That's "fixed" (waiting on proper solution, but symptoms should be gone).

Chris S: retest?
Comment 11 Matthew Flaschen 2014-08-26 03:36:54 UTC
I think this is fixed by I2488e1fd3109ce66c2cb42d9afc78097f2b7313d (the change Kunal mentioned).

I think the underlying issue is bug 69834.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links