Last modified: 2014-08-25 09:32:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71577, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69577 - When changing settings, does not default to my current setting
When changing settings, does not default to my current setting
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-14 21:43 UTC by Matthew Flaschen
Modified: 2014-08-25 09:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-08-14 21:43:57 UTC
When I go to "Enable Hovercards" to change my settings, it always defaults to "Read Quickly", even when I explicitly change it to "Monitor or Edit", save, then re-open the dialog to check the setting.

Tested in Firefox/Iceweasel 30.0
Comment 1 Matthew Flaschen 2014-08-14 21:49:51 UTC
This is tested on English Wikipedia on 1.24wmf16.
Comment 2 Matthew Flaschen 2014-08-19 04:47:27 UTC
This may not make sense to fix in isolation.

Prateek and I talked about some broader areas where the current UI may be confusing.

We also talked about possible parts of the solution, including dropping "Turn Previews off" and relying on the standard BetaFeatures UI for disabling beta features.  That then simplifies the internal preferences needed, which opens up possibilities.
Comment 3 Prateek Saxena 2014-08-20 10:43:55 UTC
(In reply to Matthew in comment #2)

> We also talked about possible parts of the solution, including dropping "Turn Previews off" and relying on the standard BetaFeatures UI for disabling beta features.

I had forgotten why we had added the settings in the first place while we were having our conversation. After speaking with Nick I remembered that we'll be making it a default feature (for all logged in and logged out users) on a few wikis that have shown interest. 

Which is why we'll have to keep it the way it is. This pattern is being used by ReferencePopups too which is a gadget that is enabled by default for all users.



(In reply to Matthew in comment #0)

> When I go to "Enable Hovercards" to change my settings, it always defaults to "Read Quickly"

I think this is justified. The link says "/Enable/ hovecards" and not "Open settings" so it is correct for it to select that option.
Comment 4 Prateek Saxena 2014-08-20 10:44:41 UTC
I apologize for the confusion. I've been causing too many of them lately.
Comment 5 Matthew Flaschen 2014-08-21 01:18:40 UTC
(In reply to Prateek Saxena from comment #3)
> I had forgotten why we had added the settings in the first place while we 
> were having our conversation. After speaking with Nick I remembered that 
> we'll be making it a default feature (for all logged in and logged out users) 
> on a few wikis that have shown interest.

It can still be a normal preference on those wikis, defaulted to true.  E.g. VisualEditor has multiple modes, including one where a regular preference is shown, and another where a beta feature is shown.

> Which is why we'll have to keep it the way it is. This pattern is being used 
> by ReferencePopups too which is a gadget that is enabled by default for all 
> users.

Gadgets have very different UX considerations, since they can not use normal preferences.

Note, currently (in production) I see both popups (I think this is meant to be fixed by https://gerrit.wikimedia.org/r/#/c/141668/ , not yet deployed) and no "Disable HoverCards" link when in "Read quickly mode".  This is arguably inconsistent, although you still have another way of disabling it (the gear).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links