Last modified: 2014-08-26 04:38:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71579, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69579 - settings.open() called with incorrect parameters, causing exception


Summary:	settings.open() called with incorrect parameters, causing exception

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Popups (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-14 21:57 UTC by Matthew Flaschen
Modified:	2014-08-26 04:38 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-08-14 21:57:16 UTC

The settings.open method expects an event (to call preventDefault), but https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/e86d476a519aa1da4fb3877d8f649b8c15231686/resources%2Fext.popups.renderer.article.js#L460 is calling it incorrectly.

This is causing exceptions in production, and is not fixed on master.

Comment 1 Gerrit Notification Bot 2014-08-18 11:39:28 UTC

Change 154794 had a related patch set uploaded by Prtksxna:
Remove preventDefault from settings.open

https://gerrit.wikimedia.org/r/154794

Comment 2 Gerrit Notification Bot 2014-08-25 17:52:01 UTC

Change 154794 merged by jenkins-bot:
Remove preventDefault from settings.open

https://gerrit.wikimedia.org/r/154794

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links