Last modified: 2014-09-09 02:33:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71633, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69633 - Flow: "Thanked" item doesn't appear disabled after Thanking
Flow: "Thanked" item doesn't appear disabled after Thanking
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-15 23:54 UTC by spage
Modified: 2014-09-09 02:33 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-08-15 23:54:40 UTC
After thanking someone, the Thank post action link changes to "Thanked" and goes dead (good), but appears with the same #666 color as the other post actions "Reply ยท Edit".  "Thanked" should appear disabled with the light gray disabled color, which is #CCC for a disabled quiet button like Preview (class="mw-ui-button mw-ui-quiet" disabled="disabled").  This is a regression, see
https://trello-attachments.s3.amazonaws.com/52cb2bb5b4f69841496a78fd/53a9bb9f7f51873704c4bfe3/177x36/2eace562b77cd752677564abd02f2827/Flow_thank.gif

Adding the disabled attribute to a span is improper HTML.  I guess we could have class=mw-ui-disabled .  The LSG section for Text and anchors http://tools.wmflabs.org/styleguide/desktop/section-6.html  doesn't give examples of disabled text/anchors , its should.
Comment 1 Danny Horn 2014-08-21 17:15:58 UTC
in backlog: https://trello.com/c/kysfhuWe
Comment 2 Jon 2014-09-09 02:33:13 UTC
mw-ui-disabled doesn't exist.
Anchor links cannot be disabled (which makes me wonder if there is a button)
This requires more thought.

Should edit, reply and thank all be mw-ui-active and become mw-ui-quiet when disabled?
Also when are we going to introduce click again to undo?

Adding design tag as this needs some more thought and in current form is too vague.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links