Last modified: 2014-08-16 09:42:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71639, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69639 - Regression test failure: "The builder for vector returned a non-Skin object"
Regression test failure: "The builder for vector returned a non-Skin object"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.24rc
All All
: Unprioritized normal (vote)
: 1.24.0 release
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-16 01:50 UTC by Matthew Flaschen
Modified: 2014-08-16 09:42 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-08-16 01:50:48 UTC
https://gerrit.wikimedia.org/r/#/c/150635/ passed the gating check normally and merged.  However, the regression test failed with:

"00:54:27 1) SpecialMIMESearchTest::testMimeFiltering with data set #1 ('image/png', 'image', 'png')
00:54:27 UnexpectedValueException: The builder for vector returned a non-Skin object."

and:

"00:54:27 2) SpecialMIMESearchTest::testMimeFiltering with data set #3 ('image/*', 'image', NULL)
00:54:27 UnexpectedValueException: The builder for vector returned a non-Skin object."

Full error details: https://integration.wikimedia.org/ci/job/mediawiki-core-regression-master/7024/console

I'm guessing it was not actually caused by that change, but we'll have to track it down either way.
Comment 1 Matthew Flaschen 2014-08-16 01:51:25 UTC
Perhaps the workspace used for this test does not yet install Vector.
Comment 2 Kunal Mehta (Legoktm) 2014-08-16 05:43:22 UTC
Apparently the tests run in different orders in weird circumstances.
Comment 3 Gerrit Notification Bot 2014-08-16 05:51:08 UTC
Change 154384 had a related patch set uploaded by Legoktm:
Register a fake skin instead of a 'vector' that will fail

https://gerrit.wikimedia.org/r/154384
Comment 4 Antoine "hashar" Musso (WMF) 2014-08-16 08:48:57 UTC
side note: I will eventually get the skins cloned in the workspace :)
Comment 5 Antoine "hashar" Musso (WMF) 2014-08-16 08:50:07 UTC
Oh and I forgot: the regression test that runs on postmerge runs the whole test suite, so there might be some side effects comparing to running group of tests in parallel :-/  We will eventually phase out the sub groups in favor of running the whole test suite.
Comment 6 Gerrit Notification Bot 2014-08-16 09:42:53 UTC
Change 154384 merged by jenkins-bot:
Register a fake skin instead of a 'vector' that will fail

https://gerrit.wikimedia.org/r/154384

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links