Last modified: 2014-08-21 15:57:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71643, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69643 - VisualEditor: Keyboard shortcut dialog style differs between standalone and MW, ugly line wraps in MW
VisualEditor: Keyboard shortcut dialog style differs between standalone and M...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2014-08-28
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-16 07:17 UTC by Roan Kattouw
Modified: 2014-08-21 15:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-08-16 07:17:59 UTC
The keyboard shortcut styling is substantially different between the standalone demo and the MW integration in terms of font size. In MW, the font size is so much bigger that some shortcuts awkwardly break across lines. For instance, "Ctrl+Shift+V" is split with the "V" being on a line by itself. In SA, the font size is smaller (for the headings and the shortcuts, but not the descriptions) so this problem doesn't happen, but there the font feels a bit *too* small.
Comment 1 James Forrester 2014-08-17 10:51:13 UTC
Ed likes fiddling with this dialog, so… :-)
Comment 2 Gerrit Notification Bot 2014-08-21 13:42:25 UTC
Change 155539 had a related patch set uploaded by Esanders:
Define kbd font-family explicity in case environment overrides

https://gerrit.wikimedia.org/r/155539
Comment 3 Gerrit Notification Bot 2014-08-21 15:49:02 UTC
Change 155539 merged by jenkins-bot:
Define kbd font-family explicity in case environment overrides

https://gerrit.wikimedia.org/r/155539

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links