Last modified: 2014-08-20 22:13:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71652, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69652 - Investigate lenient handling of quotes in xml-tag attribute values
Investigate lenient handling of quotes in xml-tag attribute values
Status: NEW
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Parsoid Team
:
: 66065 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-16 23:31 UTC by WhatamIdoing
Modified: 2014-08-20 22:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-16 23:31:10 UTC
https://en.wikipedia.org/wiki/Dachshund#Coat_and_color has a complex gallery tag:

<gallery widths="200px" heights="200px" perrow="5" caption= "There are three types of dachshund, which can  be classified by their coats: short-haired, called "smooth"; long-haired; and wire-haired">
File:Wirehaired_Dachshund.jpg|A wire-haired dachshund
File:Kurzhaardackel.jpg|A short-haired dachshund
Std Dachshund 600.jpg|A long-haired standard dachshund
File:Piebald.jpg|A piebald dachshund
File:Red-merle smooth Dachshund.jpg|A dapple dachshund</gallery>


It's being displayed as raw wikitext in VisualEditor on desktop.
Comment 1 James Forrester 2014-08-17 10:41:20 UTC
This is invalid wikitext – you can't use raw " characters inside the caption of a gallery. Parsoid works just fine if you replace them with ' characters instead:

<gallery widths="200px" heights="200px" perrow="5" caption= "There are three
types of dachshund, which can  be classified by their coats: short-haired,
called 'smooth'; long-haired; and wire-haired">
File:Wirehaired_Dachshund.jpg|A wire-haired dachshund
File:Kurzhaardackel.jpg|A short-haired dachshund
Std Dachshund 600.jpg|A long-haired standard dachshund
File:Piebald.jpg|A piebald dachshund
File:Red-merle smooth Dachshund.jpg|A dapple dachshund</gallery>

I've fixed this in the article, but am moving the bug to Parsoid in case they want to comment/merge into a wider bug about escaping bad wikitext?
Comment 2 ssastry 2014-08-20 21:06:52 UTC
I imagine this is probably not that uncommon since template args and template content may use the same quotes and thus break the html tags. We've seen a few different instances of this bug now. So, maybe worth investigating what it takes to handle this form of broken wikitext a bit more leniently.
Comment 3 ssastry 2014-08-20 22:13:17 UTC
*** Bug 66065 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links