Last modified: 2014-08-19 17:31:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71669, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69669 - Display error message instead of a PHP fatal when discouraging half-marked pages
Display error message instead of a PHP fatal when discouraging half-marked pages
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-17 17:11 UTC by Vogone
Modified: 2014-08-19 17:31 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Vogone 2014-08-17 17:11:11 UTC
When marking a page for translation, clicking at "Translate this page" leads to a "The indicated group does not exist. Select a different message group." error.
By visiting Special:PageTranslation and clicking "discourage", the page doesn't get discouraged as you would expect, but the previous error gets fixed.
Furthermore, that action gives a PHP fatal:
PHP fatal error in /usr/local/apache/common-local/php-1.24wmf16/extensions/Translate/MessageGroups.php line 305: Argument 1 passed to MessageGroups::getSharedGroups() must implement interface MessageGroup, null given, called in /usr/local/apache/common-local/php-1.24wmf16/extensions/Translate/tag/SpecialPageTranslation.php on line 93 and defined

Please give this the highest priority, as it makes the translate extension rather
impossible to use.
Comment 1 Glaisher 2014-08-18 10:58:40 UTC
Please fix this as soon as possible. As in original post, this bug makes it very difficult to use the translation extension for newly marked pages.
Comment 2 Siebrand Mazeland 2014-08-18 11:06:58 UTC
This issue talks about marking pages as "discouraged" and not as "translatable". Is that correct? Given that, I'm updating importance per https://www.mediawiki.org/wiki/Bugzilla/Fields#importance, as issues with being able to toggle "discouraged" are definitely not something that can be marked as "critical".
Comment 3 Vogone 2014-08-18 11:27:25 UTC
Nope, "translateable" doesn't work at all and "discouraged" throws a PHP fatal. But as these errors seem to be related/dependent on each other, I filed them as one bug.
Comment 4 Glaisher 2014-08-18 11:29:46 UTC
There are two problems.

1) Mark a page for translation for the first time. Click on the "Translate this page" link. This gives a "The indicated group does not exist. Select a different message group." (MediaWiki:Tux-translate-page-no-such-group) message instead of the usual translating interface.

2) After this, trying to discourage the translation of that page gives the PHP fatal error above.

After some time, this problem seems to be fixed on its own automatically. In other words, it is possible to translate the page and the error is not there when trying to discourage from translation.
Comment 5 Siebrand Mazeland 2014-08-18 11:37:00 UTC
(In reply to Glaisher from comment #4)
> There are two problems.

Please report each issue in separate bugs numbers. So please decide what this issue is about, use https://www.mediawiki.org/wiki/How_to_report_a_bug#Quick_recommendations_for_reports as a guide to making a report that is actionable to developers and update this issue accordingly. Thanks for your understanding.
Comment 6 Siebrand Mazeland 2014-08-18 11:41:22 UTC
Please see https://meta.wikimedia.org/w/index.php?title=Special:Log/Siebrand&limit=2

I've just tested what was claimed, and I cannot reproduce any of the two scenarios. We need precise report with steps to reproduce. This was done using 1.24wmf16 (f0701eb).
Comment 7 Glaisher 2014-08-18 12:04:07 UTC
(after some discussion on IRC)

Apparently, the first problem was due to the job queue. 2 was present because the page was not translatable in the first place. But perhaps it could give a more intuitive message instead of a Wikimedia error. 

This bug could be used to update that message that and that is of very low priority.
Comment 8 Andre Klapper 2014-08-19 15:01:32 UTC
(In reply to Glaisher from comment #7)
> Apparently, the first problem was due to the job queue. 2 was present
> because the page was not translatable in the first place.

Does your use of past tense imply that the problems don't exist anymore? 
Please clarify.
Comment 9 Vogone 2014-08-19 15:25:36 UTC
(In reply to Andre Klapper from comment #8)
> (In reply to Glaisher from comment #7)
> > Apparently, the first problem was due to the job queue. 2 was present
> > because the page was not translatable in the first place.
> 
> Does your use of past tense imply that the problems don't exist anymore? 
> Please clarify.

They do still exist occassionally, but have to do with the job queue. The only thing which could be improved is to add a more descriptive error message instead of causing a PHP fatal.

Adjusted the summary.
Comment 10 Nemo 2014-08-19 17:11:13 UTC
I could not parse the summary without reading it several times, tweaked a bit. Usually we don't consider fatals "minor", and avoiding a fatal should be easy enough; but there's little we can do to help the users when the job queue is lagging behind.
Comment 11 Vogone 2014-08-19 17:31:24 UTC
(In reply to Nemo from comment #10)
> I could not parse the summary without reading it several times, tweaked a
> bit.

Sorry and thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links