Last modified: 2014-09-18 18:06:39 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mK89H5lq
Change 155160 had a related patch set uploaded by Florianschmidtwelzow: Hide discussion button whilst it is broken https://gerrit.wikimedia.org/r/155160
What isn't working with the button? Works for me on beta labs and local :/
Patch doesn't fix issue just hides it. so removing patch for review (shouldn't be on commit either) For me going tohttp://en.m.wikipedia.beta.wmflabs.org/wiki/0.88507092515095#/random and adding a discussion closes the talk overlay but doesn't update the overlay with the new topic.. I have to hard refresh the page :/
Ah ok, i thought you mean, that the add doesn't work completly :) (The error in the console is "fixed" in this patch: https://gerrit.wikimedia.org/r/#/c/153341/ (but only by don't try to hide the talk overlay)). The main problem is adressed in this patch (with other improvements): https://gerrit.wikimedia.org/r/#/c/153957/ So i can add the bug there :) P.S.: > shouldn't be on commit either I think that a bug report should track all patches working to solve this bug, including the patches just hide/remove/deactivate the function, until it's fixed. But i don't know, how you (and others) see this :)
Change 153957 had a related patch set uploaded by Florianschmidtwelzow: Improvements to add discussion on talk page https://gerrit.wikimedia.org/r/153957
Change 155160 abandoned by Jdlrobson: Hide discussion button whilst it is broken https://gerrit.wikimedia.org/r/155160
Change 155160 restored by Jdlrobson: Hide discussion button whilst it is broken https://gerrit.wikimedia.org/r/155160
Change 155160 merged by jenkins-bot: Hide discussion button whilst it is broken https://gerrit.wikimedia.org/r/155160
Change 153957 merged by jenkins-bot: Improvements to add discussion on talk page https://gerrit.wikimedia.org/r/153957