Last modified: 2014-09-18 18:06:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71763, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69763 - The add discussion button in talk overlay doesn't work
The add discussion button in talk overlay doesn't work
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-19 23:03 UTC by Jon
Modified: 2014-09-18 18:06 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-08-19 23:03:57 UTC

    
Comment 1 Bingle 2014-08-19 23:05:14 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mK89H5lq
Comment 2 Gerrit Notification Bot 2014-08-19 23:51:41 UTC
Change 155160 had a related patch set uploaded by Florianschmidtwelzow:
Hide discussion button whilst it is broken

https://gerrit.wikimedia.org/r/155160
Comment 3 Florian 2014-08-20 01:10:26 UTC
What isn't working with the button? Works for me on beta labs and local :/
Comment 4 Jon 2014-08-20 01:49:26 UTC
Patch doesn't fix issue just hides it. so removing patch for review (shouldn't be on commit either)

 For me going tohttp://en.m.wikipedia.beta.wmflabs.org/wiki/0.88507092515095#/random and adding a discussion closes the talk overlay but doesn't update the overlay with the new topic.. I have to hard refresh the page :/
Comment 5 Florian 2014-08-20 01:57:34 UTC
Ah ok, i thought you mean, that the add doesn't work completly :) (The error in the console is "fixed" in this patch: https://gerrit.wikimedia.org/r/#/c/153341/ (but only by don't try to hide the talk overlay)).

The main problem is adressed in this patch (with other improvements):
https://gerrit.wikimedia.org/r/#/c/153957/

So i can add the bug there :)

P.S.:
> shouldn't be on commit either
I think that a bug report should track all patches working to solve this bug, including the patches just hide/remove/deactivate the function, until it's fixed. But i don't know, how you (and others) see this :)
Comment 6 Gerrit Notification Bot 2014-08-20 01:57:54 UTC
Change 153957 had a related patch set uploaded by Florianschmidtwelzow:
Improvements to add discussion on talk page

https://gerrit.wikimedia.org/r/153957
Comment 7 Gerrit Notification Bot 2014-08-22 20:37:51 UTC
Change 155160 abandoned by Jdlrobson:
Hide discussion button whilst it is broken

https://gerrit.wikimedia.org/r/155160
Comment 8 Gerrit Notification Bot 2014-09-12 17:48:22 UTC
Change 155160 restored by Jdlrobson:
Hide discussion button whilst it is broken

https://gerrit.wikimedia.org/r/155160
Comment 9 Gerrit Notification Bot 2014-09-12 22:28:48 UTC
Change 155160 merged by jenkins-bot:
Hide discussion button whilst it is broken

https://gerrit.wikimedia.org/r/155160
Comment 10 Gerrit Notification Bot 2014-09-18 18:02:14 UTC
Change 153957 merged by jenkins-bot:
Improvements to add discussion on talk page

https://gerrit.wikimedia.org/r/153957

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links