Last modified: 2014-08-20 16:53:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71784, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69784 - VisualEditor: Reinstate the semantic class on the "Save page" button
VisualEditor: Reinstate the semantic class on the "Save page" button
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-08-21
Assigned To: Sam Smith
:
Depends on:
Blocks: 69642
  Show dependency tree / graph
 
Reported: 2014-08-20 15:19 UTC by Sam Smith
Modified: 2014-08-20 16:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Smith 2014-08-20 15:19:21 UTC 
The firsteditve tour (the "first edit" tour, specialised for VE) relied on the ve-ui-toolbar-saveButton class to attach a guider to the "Save page" toolbar button. The class was removed as part of https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FVisualEditor.git/cc089d6bd3334791453c6474c56f49d4a2d243dd.

At the moment, there's no resilient selector that we can use to reference just that element. Can the class be reinstated?
Comment 1 Gerrit Notification Bot 2014-08-20 15:44:33 UTC 
Change 155280 had a related patch set uploaded by Phuedx:
Reinstate the ve-ui-toolbar-saveButton class

https://gerrit.wikimedia.org/r/155280
Comment 2 Gerrit Notification Bot 2014-08-20 16:48:27 UTC 
Change 155280 merged by jenkins-bot:
Reinstate the ve-ui-toolbar-saveButton class

https://gerrit.wikimedia.org/r/155280
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links