Last modified: 2014-08-21 04:42:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71788, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69788 - MapCacheLRU caches references to objects rather than copies of objects
MapCacheLRU caches references to objects rather than copies of objects
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-20 16:05 UTC by wctaiwan
Modified: 2014-08-21 04:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description wctaiwan 2014-08-20 16:05:15 UTC 
MapCacheLRU::set, when the $value passed in is an object, appears to just store a reference to $value rather than a copy of $value itself. This means that future changes to $value also affects the cached copy, which is probably not what we want in a cache.
Comment 1 Gerrit Notification Bot 2014-08-20 16:47:18 UTC 
Change 155292 had a related patch set uploaded by Wctaiwan:
Set and get object copies in MapCacheLRU

https://gerrit.wikimedia.org/r/155292
Comment 2 wctaiwan 2014-08-21 04:41:02 UTC 
Based on discussions with others, the current approach appears to be the expected behaviour.
Comment 3 Gerrit Notification Bot 2014-08-21 04:42:20 UTC 
Change 155292 abandoned by Wctaiwan:
Set and get object copies in MapCacheLRU

Reason:
Current cache behaviour seems to be expected. Bug 69789 is instead fixed with I94f06baf406afa538cd2b10139598442f9fc6759

https://gerrit.wikimedia.org/r/155292
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links