Last modified: 2014-09-09 16:51:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71815, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69815 - Flow: Echo flow-notification-newtopic has bad redundant "new topic" link
Flow: Echo flow-notification-newtopic has bad redundant "new topic" link
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-20 21:24 UTC by spage
Modified: 2014-09-09 16:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-08-20 21:24:26 UTC 
The HTML in the Echo flyout for flow-notification-newtopic is in part

   USERNAME created a <span class="plainlinks"><a 
 href="//en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow&amp;workflow=s0skmzpky7j5jc9e&amp;fromnotif=1" class="external text mw-echo-grey-link" rel="nofollow">new topic</a></span> 

on <a title="Talk:Flow" href="/wiki/Talk:Flow" class="mw-echo-grey-link">Talk:Flow</a>: TOPICTITLE.</div>

The link on "new topic":
* Is redundant, it takes you to the same topic as clicking elsewhere in the notification.
* Is the old-school Flowboard?workflow=<topicUUID> style instead of Topic:<topicUUID>
* Includes the hostname.

Note https://trello.com/c/S91gLxrQ changes the format of this notification, so this bug will become invalid when that is implemented.

The flow-notification-newtopic-email* messages for notification e-mails might have the same issue.
Comment 1 Danny Horn 2014-08-21 17:22:40 UTC 
in backlog: https://trello.com/c/qtqamlcT
Comment 2 Jon 2014-09-09 16:51:53 UTC 
The markup has changed (shown below)
I don't think the link is redundant nor is it bad. If anything it allows you to right click and open the page in a new tab (something that cannot be achieved by clicking elsewhere in the notification which uses default browser behaviour - usually same window)

See bug 60687 for the hostname issue.

<div class="mw-echo-title"><span class="mw-echo-title-heading">Reply test0.011237462778130869 browsertest edit</span><br>Selenium user created a <span class="plainlinks"><a rel="nofollow" class="external text mw-echo-grey-link" href="//en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA&amp;workflow=s1xjawgcfrxeyam8&amp;fromnotif=1">new topic</a></span> on <b>Talk:Flow QA</b>.</div>
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links