Last modified: 2014-10-03 08:13:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71824, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69824 - dumpHTML encounters fatal error: Cannot access protected property LocalRepo::$thumbScriptUrl
dumpHTML encounters fatal error: Cannot access protected property LocalRepo::...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
DumpHTML (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 67984
  Show dependency treegraph
 
Reported: 2014-08-21 00:45 UTC by Emufarmers
Modified: 2014-10-03 08:13 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Emufarmers 2014-08-21 00:45:02 UTC
This was reported on mediawiki-l: https://lists.wikimedia.org/pipermail/mediawiki-l/2014-August/043248.html  I'm able to reproduce it on MediaWiki 1.23.2 with both the 1.23 and master versions of dumpHTML.  It looks like this was caused by a visibility change in https://gerrit.wikimedia.org/r/#/c/97371/
Comment 1 Antoine "hashar" Musso (WMF) 2014-09-29 10:21:03 UTC
FileRepo properties have been changed to protected with by https://gerrit.wikimedia.org/r/97371  de6b4e7c which is in both REL1_23 and REL1_24

The extension needs to use the accessor instead:

  FileRepo->getThumbScriptUrl()
Comment 2 Daniel Friesen 2014-09-29 10:24:23 UTC
(In reply to Antoine "hashar" Musso from comment #1)
> FileRepo properties have been changed to protected with by
> https://gerrit.wikimedia.org/r/97371  de6b4e7c which is in both REL1_23 and
> REL1_24
> 
> The extension needs to use the accessor instead:
> 
>   FileRepo->getThumbScriptUrl()

DumpHTML doesn't read these properties, it writes them.

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDumpHTML/0df55f1c89b8c802dcd162b918fbd5fb1c35ab9a/dumpHTML.inc#L1157
Comment 3 Antoine "hashar" Musso (WMF) 2014-09-29 12:32:33 UTC
So I guess whatever *Repo class is used should pass the option 'thumbScriptUrl' which defaults to $wgThumbnailScriptPath , or override $wgThumbnailScriptPath . On initialization that would set the protected property FileRepo->thumbScriptUrl.
Comment 4 s7eph4n 2014-09-29 13:23:28 UTC
I know this will be regarded as a rhetoric question, still: Why not just revert the patch that introduced the bug?
Comment 5 Nemo 2014-10-03 08:13:36 UTC
(In reply to s7eph4n from comment #4)
> Why not just
> revert the patch that introduced the bug?

I don't know why, but I'll note this question for dumpHTML is not new, it's several years old; see e.g. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/51857/match=dumphtml
I'd trace the issue back to when it was split out of core :) (article.gmane.org/gmane.science.linguistics.wikipedia.technical/38065 ).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links