Last modified: 2014-09-04 21:33:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71864, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69864 - VisualEditor: [Regression wmf18] Save Page no longer completes save actions


Summary:	VisualEditor: [Regression wmf18] Save Page no longer completes save actions

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal major
Target Milestone:	VE-deploy-2014-08-28
Assigned To:	Roan Kattouw

URL:
Whiteboard:
Keywords:	browser-test-bug

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-21 18:19 UTC by Chris McMahon
Modified:	2014-09-04 21:33 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Save button not working after creating citation (50.10 KB, image/png) 2014-08-21 18:19 UTC, Chris McMahon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2014-08-21 18:19:07 UTC

Created attachment 16258 [details]
Save button not working after creating citation

After fixing https://bugzilla.wikimedia.org/show_bug.cgi?id=69856

Do everything to create a Citation as shown in the screen shot. 

Click Save. Save does nothing.

Comment 1 Rummana Yasmeen 2014-08-21 18:54:03 UTC

This happens while trying to save a page after adding anything in the page, not just citations.The error that appears in the console is:
Uncaught TypeError: Cannot read property 'openWindow' of null

Comment 2 Gerrit Notification Bot 2014-08-21 19:17:38 UTC

Change 155601 had a related patch set uploaded by Jforrester:
Followup 67f304a: use .openWindow(), not .open(), to open save dialog

https://gerrit.wikimedia.org/r/155601

Comment 3 Gerrit Notification Bot 2014-08-21 23:47:28 UTC

Change 155601 merged by jenkins-bot:
Followup 67f304a: use .openWindow(), not .open(), to open save dialog

https://gerrit.wikimedia.org/r/155601

Comment 4 Rummana Yasmeen 2014-09-04 21:33:17 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links