Last modified: 2014-11-12 15:16:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71926, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69926 - Flow SQL queries breaks DebugToolbar
Flow SQL queries breaks DebugToolbar
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-22 22:48 UTC by spage
Modified: 2014-11-12 15:16 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-08-22 22:48:54 UTC 
Enable https://www.mediawiki.org/wiki/Debugging_toolbar , visit a Flow board.
Some developers (using zend PHP not HHVM) get a JS error.  Appending ?debug=1 reveals mediawiki.debug.js fails accessing this.data.log because this.data is null.

We think it's because Flow's SQL queries of binary(11) columns involve strings like "�#�����o~p".  Shahyar Ghobadpour found that in his case the PHP conversion to JSON fails so the expected data structure isn't present. He has a gerrit patch https://gerrit.wikimedia.org/r/#/c/155832/
Comment 1 Gerrit Notification Bot 2014-08-22 22:57:09 UTC 
Change 155832 had a related patch set uploaded by Legoktm:
Fix malformed UTF-8 going to query profiler

https://gerrit.wikimedia.org/r/155832
Comment 2 Gerrit Notification Bot 2014-09-10 11:45:51 UTC 
Change 155832 merged by jenkins-bot:
Fix malformed UTF-8 going to query profiler

https://gerrit.wikimedia.org/r/155832
Comment 3 Andre Klapper 2014-11-12 15:16:16 UTC 
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links