Last modified: 2014-09-30 14:49:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71937, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69937 - ContentTranslation has hardcoded wikipedia.org URLs


Summary:	ContentTranslation has hardcoded wikipedia.org URLs

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ContentTranslation (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Niklas Laxström

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-23 12:31 UTC by Amir E. Aharoni
Modified:	2014-09-30 14:49 UTC (History)
CC List:	10 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2014-08-23 12:31:07 UTC

Quite a lot of ContentTranslation code has hardcoded wikipedia.org URLs.

It's true that the first target for CX is Wikipedia, but it shouldn't be hardcoded. The variable $wgContentTranslationDomainTemplate should be used instead.

Comment 1 Santhosh Thottingal 2014-09-23 04:40:33 UTC

Niklas worked on this. https://gerrit.wikimedia.org/r/#/c/161179/
But some more modules use $wgContentTranslationDomainTemplate

Comment 2 Santhosh Thottingal 2014-09-29 07:58:58 UTC

$ ack-grep wikipedia modules/
modules/header/styles/ext.cx.header.less
12:     background-image: url(../images/wikipedia-logo-landscape.png);

modules/tools/ext.cx.tools.images.js
40:                     url: '//' + targetLanguage + '.wikipedia.org/w/api.php',

modules/tools/ext.cx.tools.link.js
148:                    url: '//' + language + '.wikipedia.org/w/api.php',
193:                    url: '//' + mw.cx.sourceLanguage + '.wikipedia.org/w/api.php',
619:                            href: '//' + language + '.wikipedia.org/wiki/' + title

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links