Last modified: 2014-10-23 04:07:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71951, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69951 - Special:AllPages no longer has Next link (regression?)
Special:AllPages no longer has Next link (regression?)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.24rc
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: MZMcBride
: code-update-regression, easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-24 01:15 UTC by Donald Lancon
Modified: 2014-10-23 04:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
legoktm.wikipedia: Backport_to_Stable+


Attachments

Description Donald Lancon 2014-08-24 01:15:34 UTC
In some recent version of MW (have noticed in 1.24wmf17, but possibly before?), the "Next" link(s) no longer appear on Special:AllPages. Strangely, "Previous" links are provided (once you actually search for something), even if one has not actually come from any previous page! It is not at all what users (new or old) would expect.

This is a significant loss of usability. Users can no longer just click through to continue the page list; they have to copy the last page title in the list, paste it into the "Display pages starting at:" box, and hit "Go" again. Terrible.

If you need a specific example, see:
https://www.mediawiki.org/wiki/Special:AllPages

BTW, Special:PrefixIndex has a "Next" link (when appropriate), but no "Previous" link once you get to the next page. A less serious problem, of course, since the user can always use their browser's "Back" button, but still... seems strange.

(Note: I guess this technically constitutes a return to the very ancient bug 1331. Maybe I was supposed to just reopen that one??)
Comment 1 JAn Dudík 2014-09-09 05:32:04 UTC
There is also missing overview page.
Recently there was first page with some groups like
* !-Beef
* Beef-Guam
* Guar-Yello
* Yellow-some_special_character

so users were able to go to requested page with clicking only (no typing) and it was usable for checking from which letter there are more or less articles.
Comment 2 Donald Lancon 2014-09-09 14:54:41 UTC
That was shown when the wiki had more than a certain number of articles (I don't know what the threshold was). For extremely large wikis, there were multiple levels of such index pages (or whatever the technical term is for them).

That is, one such "range of articles" link, say, Actinium-Bookcase, would lead to another list of "range of articles" links, say,
* Actinium-Archive
* Archos-Asterisk
* ...
* Boardwalk-Bookcase

Yeah, those are gone now, too.
Comment 3 Romaine 2014-10-23 02:42:28 UTC
This problem still exists, can it please be solved. Special:AllPages is now almost useless or totally clumsy in use.
Comment 4 MZMcBride 2014-10-23 02:50:13 UTC
(In reply to Donald Lancon from comment #0)
> (Note: I guess this technically constitutes a return to the very ancient bug
> 1331. Maybe I was supposed to just reopen that one??)

You were correct to file this bug. It's a very good bug report. Thanks. :-)

We're presumably talking about https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fspecials%2FSpecialAllPages.php though I wouldn't be surprised if the pagination logic were shared... I'll poke at this.
Comment 5 MZMcBride 2014-10-23 03:16:57 UTC
Right, so https://gerrit.wikimedia.org/r/145761 did this (specifically <https://gerrit.wikimedia.org/r/#/c/145761/1/includes/specials/SpecialAllPages.php,unified>). It removed the $n++ line, which is later used at <https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/includes%2Fspecials%2FSpecialAllPages.php#L307>:

if ( $n == $this->maxPerPage && $s = $res->fetchObject() ) {

Because $n isn't getting incremented any longer, it never equals $maxPerPage (which is set to 345... no idea why, probably aesthetics).
Comment 6 Gerrit Notification Bot 2014-10-23 03:41:55 UTC
Change 168248 had a related patch set uploaded by MZMcBride:
Restore next link to Special:AllPages

https://gerrit.wikimedia.org/r/168248
Comment 7 Gerrit Notification Bot 2014-10-23 03:49:46 UTC
Change 168249 had a related patch set uploaded by Legoktm:
Restore next link to Special:AllPages

https://gerrit.wikimedia.org/r/168249
Comment 8 Gerrit Notification Bot 2014-10-23 03:54:37 UTC
Change 168248 merged by jenkins-bot:
Restore next link to Special:AllPages

https://gerrit.wikimedia.org/r/168248
Comment 9 Gerrit Notification Bot 2014-10-23 03:56:58 UTC
Change 168249 merged by jenkins-bot:
Restore next link to Special:AllPages

https://gerrit.wikimedia.org/r/168249
Comment 10 Kunal Mehta (Legoktm) 2014-10-23 04:07:40 UTC
Merged and backported to the 1.24 branch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links