Last modified: 2014-08-25 23:27:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71995, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69995 - Error: bad-source-ip, tools is running on Tool Labs grid
Error: bad-source-ip, tools is running on Tool Labs grid
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
unspecified
All All
: Unprioritized critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-25 21:20 UTC by metatron
Modified: 2014-08-25 23:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description metatron 2014-08-25 21:20:40 UTC
OAuth tool xtools is currently experiencing errors, when trying to log in.

https://tools.wmflabs.org/xtools/articleinfo/?login
Error: bad-source-ip

The tool is running on Tool Labs Grid (currently host: tools-webgrid-03 )
https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Overview
Comment 1 Brad Jorsch 2014-08-25 21:26:31 UTC
"bad-source-ip" happens if the IPAddresses restriction you configured when setting up the consumer doesn't pass the IP address actually being seen at the server. What restrictions do you have configured (or what is the consumer so I can check the DB), and what is the IP address being used?
Comment 2 Brad Jorsch 2014-08-25 21:28:23 UTC
(note you can test the IP being used by hitting api.php?action=query&meta=userinfo while logged out)
Comment 3 metatron 2014-08-25 21:58:06 UTC
Configured restriction is:
{"IPAddresses":["208.80.155.0/24","::/0"]}
and all worked until 2-4 days ago. No changes on my side.
Comment 4 metatron 2014-08-25 22:08:27 UTC
And yep. it reports to api the grid-host's internal ip
{"query":{"userinfo":{"id":0,"name":"10.68.17.123","anon":""}}}
Comment 5 Brad Jorsch 2014-08-25 22:11:06 UTC
When I hit enwiki from tools-webgrid-03, it tells me the IP address is 10.68.17.123. Thus the feature is working as intended.

You might want to ask Tool Labs admins whether anything changed recently where it is now using IPv4 instead of IPv6 or is now using internal IPs rather than external.
Comment 6 Chris Steipp 2014-08-25 22:23:23 UTC
(In reply to metatron from comment #3)
> Configured restriction is:
> {"IPAddresses":["208.80.155.0/24","::/0"]}
> and all worked until 2-4 days ago. No changes on my side.

I merged a patch last week that actually threw an exception when this happened. I think that is what caused the error to start showing up.

App owners can update the restrictions for their app to allow those private IP addresses.
Comment 7 metatron 2014-08-25 23:27:05 UTC
Well, the new restrictions now allow private labs addresses too.
This was necessary due to the change.

{"IPAddresses":["208.80.155.0/24","10.68.16.0/24","10.68.17.0/24","::/0"]}

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links