Last modified: 2014-11-19 10:22:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71998, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69998 - Vector: h3 should not appear as heavier weight than h2
Vector: h3 should not appear as heavier weight than h2
Status: PATCH_TO_REVIEW
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-25 21:47 UTC by Isarra
Modified: 2014-11-19 10:22 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Headers on enwp (60.14 KB, image/png)
2014-09-23 19:51 UTC, Isarra
Details
Headers on enwp (windows) (29.57 KB, image/png)
2014-09-23 19:52 UTC, Isarra
Details
Headings test Mac/chrome (88.82 KB, image/png)
2014-09-23 20:25 UTC, Jared Zimmerman (WMF)
Details
URLs in comment 13; Firefox 32 private session (logged out), 100% zoom, Fedora 20 (28.45 KB, image/png)
2014-09-23 22:18 UTC, Andre Klapper
Details

Description Isarra 2014-08-25 21:47:27 UTC
The h3s in vector are bolder than and subsequently can appear a bit bigger than h2s, despite being less important than h2s.

Headers should appear with decreasing apparent importance according to which header they are.
Comment 1 Gerrit Notification Bot 2014-09-23 18:45:54 UTC
Change 162304 had a related patch set uploaded by Legoktm:
Make h1-6 sizes consistently different

https://gerrit.wikimedia.org/r/162304
Comment 2 Jared Zimmerman (WMF) 2014-09-23 18:49:09 UTC
I'm not able to reproduce this. I'm seeing H2 and H3 as visually identical, but properly affecting the information hierarchy in the TOC, which seems reasonable to me. I'm not sure I see the value in a proliferation of stylistic differences from H1-H5 beyond what is absolutely necessary.
Comment 3 Bartosz Dziewoński 2014-09-23 19:25:27 UTC
Jared, your system must be horribly misconfigured then. Can you provide a screenshot? For a more visible effect, try looking at a page in Russian, Arabic, Hebrew or Chinese, as in all of these languages (and probably many more) the effect is a lot more profound than in languages using the Latin alphabet.
Comment 4 Jared Zimmerman (WMF) 2014-09-23 19:28:50 UTC
Bartosz, can you provide a link to a page where the effect is prominent.
Comment 5 Jon 2014-09-23 19:29:04 UTC
Bartosz can you provide a screenshot? This could be platform specific.
Comment 6 Isarra 2014-09-23 19:51:18 UTC
Created attachment 16564 [details]
Headers on enwp

Screenshot of https://en.wikipedia.org/wiki/User:Isarra/header_test

The h3 text is much heavier than the h2. Due to the different fonts, you can also see how the h3 can appear longer on some linux systems.

I'm afraid I don't have a testpage for any of the other languages Bartosz mentioned, but even in english you get the point.
Comment 7 Isarra 2014-09-23 19:52:25 UTC
Created attachment 16565 [details]
Headers on enwp (windows)

Same thing, different fonts.
Comment 8 Jared Zimmerman (WMF) 2014-09-23 20:06:35 UTC
Looks like a weird platform specific bug then?
Comment 9 Isarra 2014-09-23 20:19:51 UTC
(In reply to Jared Zimmerman (WMF) from comment #8)
> Looks like a weird platform specific bug then?

If 'everything that isn't your personal computer' is 'platform specific', perhaps. The same thing holds on macs; I just don't have direct access to one or I'd have uploaded a screenshot of that, too.
Comment 10 Jon 2014-09-23 20:23:05 UTC
Isarra I personally see nothing wrong in that screenshot.

There is nothing that says an h3 need to be a stronger font weight than h2.

I can tell the h2 is more important than the h3 as:
* it has an underline
* it has a bigger font size
* it has larger line height/margins
Comment 11 Jared Zimmerman (WMF) 2014-09-23 20:25:04 UTC
Created attachment 16566 [details]
Headings test Mac/chrome

I've added the example as rendered on mac chrome (safari is indistinguishable)
Comment 12 Isarra 2014-09-23 20:38:18 UTC
(In reply to Jon from comment #10)
> Isarra I personally see nothing wrong in that screenshot.
> 
> There is nothing that says an h3 need to be a stronger font weight than h2.
> 
> I can tell the h2 is more important than the h3 as:
> * it has an underline
> * it has a bigger font size
> * it has larger line height/margins

Aye, by itself the weight difference is by no means a major issue. The underline and margins on the h2 do effectively indicate that it's supposed to be more important, but even so, the h3s are... strange. Due to the bolding and font differences effective weight of the h3s is significantly higher than the h2s, and why? It looks strange, and there's really no good reason for this.

So why not make it better? That's all this is about.


For a bit of history, this issue has actually been present in monobook since its release, with vector merely inheriting the header styles from that. The typography refresh may have made it stand out more (especially on some platforms) due to the different fonts, however: serif fonts tend to be a lot lighter in general than sans-serif, which is also part of why they've historically been regarded as so bad for screen use, and the different fonts in the serif stack also have quite a bit of variation in their own sizes, which can make the effect even more pronounced depending on which gets used.

But that just means the serif stack should be applied to all the headers so it doesn't matter, that's all. Beyond that the fix is still pretty much exactly the same here as it would be for monobook.
Comment 13 Bartosz Dziewoński 2014-09-23 21:15:17 UTC
(In reply to Jared Zimmerman (WMF) from comment #4)
> Bartosz, can you provide a link to a page where the effect is prominent.

Try these:

https://en.wikipedia.org/wiki/San_Francisco#Education
https://he.wikipedia.org/wiki/סן_פרנסיסקו#.D7.90.D7.AA.D7.A8.D7.99.D7.9D_.D7.91.D7.A2.D7.9C.D7.99_.D7.97.D7.A9.D7.99.D7.91.D7.95.D7.AA
https://zh.wikipedia.org/wiki/旧金山#.E6.97.85.E9.81.8A
https://ru.wikipedia.org/wiki/Сан-Франциско#.D0.9E.D0.B1.D1.80.D0.B0.D0.B7.D0.BE.D0.B2.D0.B0.D0.BD.D0.B8.D0.B5

This is the article about San Francisco. How bad the headings look depends on the language, with some it's mostly okay, with some it's awful.

There are no links above to a wiki in Arabic script, because it seems that they all overrode the "typography refresh" styles to restore sans-serif headings. I guess it looked *that* bad there.
Comment 14 Jared Zimmerman (WMF) 2014-09-23 21:45:39 UTC
Bartosz, I think from this we can surmise the problem primarily exists in windows, as I'm not seeing anything I would refer to as confusing, or awful on a mac in chrome or safari, so the question remains, "Why are these rendering an such a different way across platforms?" 

If the bug report is read literally, that H3s should not be bold, OR H2s should be bold, OR that H2s should be bold and H3s should not I'm not sure I agree with that. As Jon pointed out, I have no issue clearly differentiating between H2s and H3s and aside from this bug, I've not heard this issue from any significant number of users.
Comment 15 Andre Klapper 2014-09-23 22:18:48 UTC
Created attachment 16568 [details]
URLs in comment 13; Firefox 32 private session (logged out), 100% zoom, Fedora 20
Comment 16 Isarra 2014-09-24 16:40:34 UTC
Related: Bug 71240 - Re-evaluate serif font stack for headers

(I know bugzilla has a thing for related bugs somewhere, but the interface doesn't really give any hints as to which field that actually is.)
Comment 17 Jesús Martínez Novo (Ciencia Al Poder) 2014-09-24 16:47:34 UTC
(In reply to Isarra from comment #16)
> Related: Bug 71240 - Re-evaluate serif font stack for headers
> 
> (I know bugzilla has a thing for related bugs somewhere, but the interface
> doesn't really give any hints as to which field that actually is.)

"See also" field :)
Comment 18 Isarra 2014-09-24 16:48:52 UTC
Thanks.
Comment 19 Gerrit Notification Bot 2014-09-25 15:44:04 UTC
Change 162304 had a related patch set uploaded by Bartosz Dziewoński:
Make h1-6 sizes consistently different

https://gerrit.wikimedia.org/r/162304
Comment 20 Gerrit Notification Bot 2014-10-04 00:41:59 UTC
Change 164712 had a related patch set uploaded by Isarra:
Adjust header sizes to scale apparent size according to header weight

https://gerrit.wikimedia.org/r/164712

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links