Last modified: 2014-09-12 18:16:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72015, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70015 - VisualEditor: Open button in link inspector should be disabled when the link target field is empty


Summary:	VisualEditor: Open button in link inspector should be disabled when the link ...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	VE-deploy-2014-09-04
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-26 00:06 UTC by Rummana Yasmeen
Modified:	2014-09-12 18:16 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (112.57 KB, image/png) 2014-08-29 20:51 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-08-26 00:06:26 UTC

Comment 1 Rummana Yasmeen 2014-08-26 00:08:57 UTC

Right now, when you open link inspector and keep the link target field empty, you will still be able to click on "Open" button as it remains active, though it serves no purpose.We should disable it in this case

Comment 2 Gerrit Notification Bot 2014-08-27 17:36:20 UTC

Change 156582 had a related patch set uploaded by Alex Monk:
Link target input widget: Make '' an invalid link target

https://gerrit.wikimedia.org/r/156582

Comment 3 Gerrit Notification Bot 2014-08-28 00:04:46 UTC

Change 156582 merged by jenkins-bot:
Link target input widget: Make '' an invalid link target

https://gerrit.wikimedia.org/r/156582

Comment 4 Rummana Yasmeen 2014-08-28 20:59:07 UTC

The "Open" button is now getting disabled when you clear the link target name , but if you just open the link inspector in any empty line and there is no link target name specified yet , the "Open" button still remains enabled

Comment 5 Alex Monk 2014-08-29 00:29:44 UTC

I uploaded Gerrit change #157017 to resolve that issue, and Roan just merged it. I forgot to link it to this bug, sorry!

Comment 6 Rummana Yasmeen 2014-08-29 20:51:56 UTC

Created attachment 16315 [details]
Screenshot

hmm..but I still see that button as active :/

Comment 7 Alex Monk 2014-08-29 21:20:53 UTC

Works for me. Gerrit change #157212 should've sent my fix to beta labs.

Comment 8 Rummana Yasmeen 2014-08-29 21:29:55 UTC

Yeah, just started working for me! Marking as Resolved .

Comment 9 Rummana Yasmeen 2014-09-04 21:10:04 UTC

Again in production, the "open" button remains enabled when I open a link inspector in a blank line without selecting a text.I will wait for a while to see whether it gets started working automatically like it did in Betalabs.Reopening it for now.

Comment 10 Alex Monk 2014-09-04 22:20:10 UTC

I just tested this on MediaWiki.org and it seems to have been fixed. . .

Comment 11 Alex Monk 2014-09-04 22:28:12 UTC

So the first patch set I made (to deal with existing links when you clear the target page) should be deployed to all Wikimedia wikis. But the second one (per Rummana's comment 4) was merged a day later which just happened to put it on the next deployment version (so it should be another week).

Comment 12 Rummana Yasmeen 2014-09-12 18:16:48 UTC

Verified the fix in Production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links