Last modified: 2014-09-02 18:29:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72044, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70044 - [DM 1.0 compat] Fix ChangeOpsMergeTest errors
[DM 1.0 compat] Fix ChangeOpsMergeTest errors
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=2 s=2014-08-26
:
Depends on:
Blocks: 70039
  Show dependency tree / graph
 
Reported: 2014-08-26 14:48 UTC by tobias.gritschacher
Modified: 2014-09-02 18:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description tobias.gritschacher 2014-08-26 14:48:06 UTC 
There were 4 errors:

1) Wikibase\Test\ChangeOpsMergeTest::testCanApply with data set "claimMerge" (array(array(array(array('novalue', 56), array(), 'Q111$D8404CDA-25E4-4334-AF13-A390BCD9C556'))), array(), array(), array(array(array(array('novalue', 56), array(), 'Q111$D8404CDA-25E4-4334-AF13-A390BCD9C556'))))
InvalidArgumentException: Can't handle claims with no GUID set!

/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:81
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:279
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:49
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:412
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:408
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsMergeTest.php:164

2) Wikibase\Test\ChangeOpsMergeTest::testCanApply with data set "claimWithQualifierMerge" (array(array(array(array('novalue', 56), array(array('novalue', 56)), 'Q111$D8404CDA-25E4-4334-AF13-A3290BCD9C0F'))), array(), array(), array(array(array(array('novalue', 56), array(array('novalue', 56)), 'Q111$D8404CDA-25E4-4334-AF13-A3290BCD9C0F'))))
InvalidArgumentException: Can't handle claims with no GUID set!

/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:81
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:279
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:49
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:412
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:408
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsMergeTest.php:164

3) Wikibase\Test\ChangeOpsMergeTest::testCanApply with data set "itemMerge" (array(array('foo', 'ptfoo'), array('foo', 'pldesc'), array(array('foo', 'bar'), array('defoo', 'debar')), array(array('foo', array())), array(array(array('novalue', 88), array(array('novalue', 88)), 'Q111$D8404CDA-25E4-4334-AF88-A3290BCD9C0F'))), array(), array(), array(array('foo', 'ptfoo'), array('foo', 'pldesc'), array(array('foo', 'bar'), array('defoo', 'debar')), array(array('foo', array())), array(array(array('novalue', 88), array(array('novalue', 88)), 'Q111$D8404CDA-25E4-4334-AF88-A3290BCD9C0F'))))
InvalidArgumentException: Can't handle claims with no GUID set!

/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:81
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:279
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:49
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:412
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:408
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsMergeTest.php:164

4) Wikibase\Test\ChangeOpsMergeTest::testCanApply with data set "ignoreConflictItemMerge" (array(array('foo', 'ptfoo'), array('foo', 'pldesc'), array(array('foo', 'bar'), array('defoo', 'debar')), array(array('foo', array()), array('bar', array())), array(array(array('novalue', 88), array(array('novalue', 88)), 'Q111$D8404CDA-25E4-4334-AF88-A3290BCD9C0F'))), array(array('toLabel'), array('toLabel'), array(array('toLink', array()))), array(array('foo'), array('pldesc'), array(array('bar', array()))), array(array('toLabel', 'ptfoo'), array('foo', 'toLabel'), array(array('foo', 'bar'), array('defoo', 'debar')), array(array('foo', array()), array('toLink', array())), array(array(array('novalue', 88), array(array('novalue', 88)), 'Q111$D8404CDA-25E4-4334-AF88-A3290BCD9C0F'))), array('label', 'description', 'sitelink'))
InvalidArgumentException: Can't handle claims with no GUID set!

/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:81
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:279
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Claim/Claims.php:49
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:412
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Item.php:408
/var/lib/jenkins/jobs/wikibase-repo-tests/workspace/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpsMergeTest.php:164
Comment 1 Addshore 2014-08-26 15:19:35 UTC 
I get different errors.

Argument 1 passed to Wikibase\DataModel\Statement\StatementList::addStatement() must be an instance of Wikibase\DataModel\Statement\Statement, instance of Wikibase\DataModel\Claim\Claim given, called in C:\git\gerrit\mediawiki\extensions\Wikibase\vendor\wikibase\data-model\src\Entity\Item.php on line 333 and defined
Comment 2 Jeroen De Dauw 2014-08-27 09:46:16 UTC 
That difference is caused by a recent change to DataModel. Guess the test is adding a Claim to an Item.
Comment 3 tobias.gritschacher 2014-08-28 11:12:39 UTC 
Should be fixed by changes in https://gerrit.wikimedia.org/r/#/c/153714/
Comment 4 Jeroen De Dauw 2014-08-28 16:28:16 UTC 
That commit has nothing to do with this particular issue
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links