Last modified: 2014-09-01 03:59:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72057, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70057 - wikiEditor not loading in a Semantic Form


Summary:	wikiEditor not loading in a Semantic Form

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	SemanticForms (Other open bugs)
Version:	REL1_23-branch
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Yaron Koren

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-26 19:06 UTC by ryan.glasnapp
Modified:	2014-09-01 03:59 UTC (History)
CC List:	0 users

See Also:	69902
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ryan.glasnapp 2014-08-26 19:06:28 UTC

I get this error popup when trying to use wikiEditor. 

MW: 1.23.1
SMW: 2.0
SF: latest master (020e20e)

ext.semanticforms.wikieditor: Error: Module ext.semanticforms.wikieditor has failed dependencies

I tracked down the issue to the line in SF_wikieditor.js

if ( typeof( window.ext ) === "undefined" ) {
	window.ext = {};
}

If window.ext is null, typeof returns as object not undefined, so ultimately it ends up breaking.

Comment 1 Yaron Koren 2014-08-26 19:42:00 UTC

If you get rid of or comment out those lines, does it work for you?

Comment 2 ryan.glasnapp 2014-08-27 19:45:17 UTC

If I comment out the entire if statement, it still breaks. 

If I just comment out the "if" parts, and leave the window.ext = {} it works.

Comment 3 Yaron Koren 2014-08-28 15:27:25 UTC

Okay, that's good to know, thanks.

Comment 4 Gerrit Notification Bot 2014-09-01 03:56:10 UTC

Change 157639 had a related patch set uploaded by Yaron Koren:
Added null check for window.ext - fix for bug 70057

https://gerrit.wikimedia.org/r/157639

Comment 5 Gerrit Notification Bot 2014-09-01 03:58:50 UTC

Change 157639 merged by Yaron Koren:
Added null check for window.ext - fix for bug 70057

https://gerrit.wikimedia.org/r/157639

Comment 6 Yaron Koren 2014-09-01 03:59:41 UTC

I believe this is now fixed - feel free to re-open if not.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links