Last modified: 2014-10-28 14:44:49 UTC
In the past Apache configs were in the apache-config repo. When they were there and since Tim Starling wrote the generator for redirects you had to edit redirects.dat, then generate redirects.conf from that and upload both to Gerrit. Then jenkins would check if they matched and vote on that. Then, the Apache configs have been moved into the mediawiki module (which i'm not entirely sure i support because many redirects have nothing to do with mediawiki, but that's not the point here). The point of this bug is that now f.e. on https://gerrit.wikimedia.org/r/#/c/149890/ you can see how it's possible to change just the .dat file, not upload the .conf file, but jenkins doesn't say anything about it, where it should vote it down. That is a regression compared to for example https://gerrit.wikimedia.org/r/#/c/146334/. Can we have the Apache lint checks back even though now the configs are in the Mediawiki module?
also i'm going to note that now a change as the one above turns into "puppet merge" & "apache deployment" at the same time if merged both has to be done, and this could have broken all the redirects
Do we know when this behavior changed?
I am just noticing this bug :-/ The apache configuration got moved from the standalone repository operations/apache-config.git to puppet. The Jenkins job need to be ported as well.
Change 163812 had a related patch set uploaded by Hashar: Reenable Apache lint check https://gerrit.wikimedia.org/r/163812
Change 163813 had a related patch set uploaded by Hashar: Retrigger operations-apache-config-lint (non voting) https://gerrit.wikimedia.org/r/163813
Change 163813 merged by jenkins-bot: Retrigger operations-apache-config-lint (non voting) https://gerrit.wikimedia.org/r/163813
I have adjusted the job to clone both operations/puppet.git and operations/mediawiki-config.git using Zuul cloner: https://gerrit.wikimedia.org/r/#/c/163812/ . It is deployed though there is a mass amount of sed scripts which I am not fan of. The job pass, but I am not sure whether it catch all potentials issues that might occurs in Apache configuration files. We need to propose patches to verify the job is failing properly. I have update Zuul configuration ( https://gerrit.wikimedia.org/r/#/c/163813/ ) to trigger the job on both puppet and mediawiki-config repositories.
I have proposed two test changes to play with, both have a build passing when doing a noop change: operations/puppet: https://gerrit.wikimedia.org/r/#/c/163814/ https://integration.wikimedia.org/ci/job/operations-apache-config-lint/569/console operations/mediawiki-config: https://gerrit.wikimedia.org/r/#/c/163815/ https://integration.wikimedia.org/ci/job/operations-apache-config-lint/570/console The patchsets can be reused to propose bad configurations and verify the job are failing properly. Whenever that is known to work, we can make them voting and hence vote Verified -2 in Gerrit.
Change 166033 had a related patch set uploaded by Hashar: Reenable Apache lint check https://gerrit.wikimedia.org/r/166033
Change 163812 abandoned by Hashar: Reenable Apache lint check Reason: Migrated to integration/config.git as https://gerrit.wikimedia.org/r/#/c/166033/ https://gerrit.wikimedia.org/r/163812
Patch is pending peer reviewing/testing to verify the test script would properly detects issues.
