Last modified: 2014-09-23 22:06:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72074, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70074 - VisualEditor: .topicon icons are taking editors to linked pages, rather than letting them edit the template, in MonoBook on English Wikipedia
VisualEditor: .topicon icons are taking editors to linked pages, rather than ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-09-25
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 66083
  Show dependency treegraph
 
Reported: 2014-08-27 00:36 UTC by WhatamIdoing
Modified: 2014-09-23 22:06 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-27 00:36:43 UTC
Steps to reproduce:

1.  Open page containing the {{good article}} (or similar) template in VisualEditor, such as https://en.wikipedia.org/w/index.php?oldid=622810787 (which contains only that template)

2.  Click the good article icon/template

3.  VisualEditor exits, and you are reading the Wikipedia:Good article page (the same one that you would be reading if you clicked that icon in 'read' mode).


Expected behavior:

1.  Open page containing {{good article}} in VisualEditor

2.  Click the good article icon/template

3.  Edit the template just like any other.


It's possible that this can only be reproduced on Windows, because on my Mac, when I open the page, the template isn't even visible.
Comment 1 Derk-Jan Hartman 2014-08-27 09:38:11 UTC
Which browsers are you using ?
Comment 2 WhatamIdoing 2014-08-27 15:17:15 UTC
It was reported on Firefox 31 on Windows 7, using Monobook.

There's a screenshot at https://commons.wikimedia.org/wiki/File:VE_with_GA_icon.png
Comment 3 Bartosz Dziewoński 2014-09-22 15:09:53 UTC
Caused by "z-index: 10;" in [[w:en:MediaWiki:Monobook.css]].
Comment 4 Bartosz Dziewoński 2014-09-22 15:16:27 UTC
While this could possibly be fixed on-wiki for this particular case, we should prevent people from accidentally or intentionally breaking this in VE, too.
Comment 5 Ed Sanders 2014-09-22 15:28:07 UTC
Setting topicons with CSS like this is a horrible hack. Imagine if we did the same with category links!

We should create a simple extension to add topicons to a page, so that they are rendered in the correct place in the HTML (i.e. not the article body). Parsoid can then provide them to VE as metadata and we can handle them accordingly.

I've discussed this with Trevor and Roan and we think it's a fairly simple project to take on.
Comment 6 Gerrit Notification Bot 2014-09-22 15:30:00 UTC
Change 161957 had a related patch set uploaded by Bartosz Dziewoński:
Prevent page elements from displaying on top of highlights

https://gerrit.wikimedia.org/r/161957
Comment 7 Bartosz Dziewoński 2014-09-22 15:32:51 UTC
Ed, that's bug 23796, with the related bug 51420 in VE.
Comment 8 Gerrit Notification Bot 2014-09-23 22:06:36 UTC
Change 161957 merged by jenkins-bot:
Prevent page elements from displaying on top of highlights

https://gerrit.wikimedia.org/r/161957

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links