Last modified: 2014-10-08 00:48:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72078, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70078 - mobile watchlist shows deleted articles in the full list with a white star
mobile watchlist shows deleted articles in the full list with a white star
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 70798 71199 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-27 06:19 UTC by Amir E. Aharoni
Modified: 2014-10-08 00:48 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2014-08-27 06:19:17 UTC
To reproduce:

0. Log in.
1. Add a non-existent article to your watchlist.
2. Open the watchlist in list view: https://en.m.wikipedia.org/w/index.php?title=Special:Watchlist&watchlistview=a-z
3. Search for the name of the deleted article.

Observed: The star in that line is white.

Expected: The star in that line is supposed to be green. The article is in the watchlist, so it should be marked just like all others. The red color of the link already indicates that it's deleted.
Comment 1 Bingle 2014-08-27 06:20:17 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/DMwr5EoU
Comment 2 Jon 2014-09-19 17:44:07 UTC
*** Bug 70798 has been marked as a duplicate of this bug. ***
Comment 3 Jon 2014-09-23 21:49:33 UTC
Bahodir did some investigation into this. Here's what he discovered:

"My findings so far: 1. You can only watch a non-existent page in the destop version of the site. If you try to do so in the mobile version, your change to watch the page doesn't stick. Try refreshing the page and you'll see the watch start is white again.
2. The API returns missing pages with ID of 0 and no 'watched' property, which prevents us from knowing if a page has been watched or not. Also it's worth considering what happens if you watch 2 non-existing pages."

Essentially the problem we have is we use id's to control watching an article but this doesn't work for new pages which have no id. We will need to rethink this code...
Comment 4 Jon 2014-09-24 00:52:14 UTC
*** Bug 71199 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-10-07 23:51:22 UTC
Change 165398 had a related patch set uploaded by Jdlrobson:
Allow watching of missing pages

https://gerrit.wikimedia.org/r/165398
Comment 6 Gerrit Notification Bot 2014-10-08 00:47:19 UTC
Change 165398 merged by jenkins-bot:
Allow watching of missing pages

https://gerrit.wikimedia.org/r/165398

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links