Last modified: 2014-09-04 21:21:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72101, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70101 - VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templates/parameters/content gets missing from the left panel of transclusion dialog after selecting a required parameter


Summary:	VisualEditor: [Regression pre-wmf19] The trash icon for deleting other templa...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-08-28
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-27 19:46 UTC by Rummana Yasmeen
Modified:	2014-09-04 21:21 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (50.74 KB, image/png) 2014-08-27 19:46 UTC, Rummana Yasmeen	Details
The missing trash icon (61.90 KB, image/png) 2014-08-27 19:48 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-08-27 19:46:47 UTC

Created attachment 16296 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Template
3.Click on "Show Options"
4.Add the template "Cite Web"
5.Select one of those required parameter from the left panel of the dialog
6.Add some more template with some optional parameters and content in the transclusion dialog
7.Now select one of the required parameter for the "Cite Web" template from the left panel
8.Now from left panel,select any other template/optional parameter/content or even the "Cite web" template 

Observe that the trash icon that used to appear at the corner of the left panel for other template/optional parameter/content or "Cite web" template are not appearing now.


See the screenshots attached

Comment 1 Rummana Yasmeen 2014-08-27 19:48:41 UTC

Created attachment 16297 [details]
The missing trash icon

Comment 2 Gerrit Notification Bot 2014-08-27 20:00:44 UTC

Change 156671 had a related patch set uploaded by Alex Monk:
Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages

https://gerrit.wikimedia.org/r/156671

Comment 3 Gerrit Notification Bot 2014-08-27 21:28:35 UTC

Change 156671 merged by jenkins-bot:
Toggle trash button (on transclusion dialog) visibility when changing to non-parameter pages

https://gerrit.wikimedia.org/r/156671

Comment 4 Rummana Yasmeen 2014-08-27 22:30:36 UTC

Verified the fix in Betalabs

Comment 5 Rummana Yasmeen 2014-08-28 21:08:12 UTC

Verified the fix in test2

Comment 6 Rummana Yasmeen 2014-09-04 21:21:07 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links