Last modified: 2014-09-02 23:56:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72131, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70131 - $wgVisualEditorParsoidForwardCookies should be unconditional
$wgVisualEditorParsoidForwardCookies should be unconditional
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-28 18:46 UTC by Marc A. Pelletier
Modified: 2014-09-02 23:56 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marc A. Pelletier 2014-08-28 18:46:46 UTC
There are use cases where the edit permission is allowed to '*' yet a cookie is necessary for editing certain pages (or, in my specific use case, certain unflagged revisions).

Having $wgVisualEditorParsoidForwardCookies ignored in those cases cause obscure 500 errors on VE startup.

It's not clear to me why that setting is only conditionally obeyed; if the wiki is configured so that any page really /can/ be edited, then just not setting that variable to true does the trick.
Comment 1 Marc A. Pelletier 2014-08-28 18:48:45 UTC
s/true/false/ obviously.
Comment 2 Roan Kattouw 2014-08-29 02:18:42 UTC
(In reply to Marc A. Pelletier from comment #0)
> There are use cases where the edit permission is allowed to '*' yet a cookie
> is necessary for editing certain pages
This setting is only relevant if a cookie is required to *read* certain pages. Is that what is being restricted in your case?

Because in that case, whatever extension is used to achieve this read restriction should probably do something that causes User::isEveryoneAllowed( 'read' ) to return false (there's a hook for that).
Comment 3 Marc A. Pelletier 2014-08-29 04:06:48 UTC
Yes, a combination of FR and a TitleReadWhitelist to only allow users to read flagged revisions unless they are the editor.  I was not aware there's a hook to prevent isEveryoneAllowed, that seems to be a good way to fix this.

That said, I'm still a little puzzled on the necessity to ignore an explicitly set configuration variable in the case where it appears unnecessary.  *shrug*
Comment 4 Marc A. Pelletier 2014-08-29 04:07:12 UTC
... a TitleReadWhitelist [hook] ...
Comment 5 Roan Kattouw 2014-08-29 17:47:01 UTC
(In reply to Marc A. Pelletier from comment #3)
> That said, I'm still a little puzzled on the necessity to ignore an
> explicitly set configuration variable in the case where it appears
> unnecessary.  *shrug*

Yeah, I'm not so sure that was a good decision in hindsight, but I also don't feel very comfortable changing the behavior in a way that will make it less secure for some people.
Comment 6 Marc A. Pelletier 2014-09-02 23:56:57 UTC
As designed, then.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links