Last modified: 2014-09-15 15:30:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72132, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70132 - [scap] Syncing a dblist referencing a nonexistent DB should be prevented
[scap] Syncing a dblist referencing a nonexistent DB should be prevented
Status: NEW
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-28 18:47 UTC by Bryan Davis
Modified: 2014-09-15 15:30 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-08-28 18:47:52 UTC
Imported from RT #550:

sync-dblist and other scripts that synchronize dblists (I think scap does this, maybe sync-common-all does as well) should check that each DB listed in each dblist exists and refuse to sync if that's not the case.  This was suggested on wikitech-l after SUL broke due to the addition of a nonexistent DB to all.dblist . I've also previously broken SUL the same way by adding an empty line to all.dblist .

See https://lists.wikimedia.org/pipermail/wikitech-l/2011-January/051347.html

[Editor's note: url changed from RT ticket to point to what I think is the correct email thread.]
Comment 1 Bryan Davis 2014-08-28 18:52:02 UTC
1) How do we verify that a db exists? Attempt to connect to it via a maintenance script or other means?
2) Do all dblist files need to be checked or just all.dblist?
Comment 2 Antoine "hashar" Musso (WMF) 2014-09-15 15:30:49 UTC
If we ever manage to publicly expose the list of database name actually deployed on the cluster, we could then add an integration test on operations/mediawiki-config.git that would refuse to have the .dblist change merged.  Fail early for the win!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links