Last modified: 2014-08-29 01:21:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72137, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70137 - [Regression] Flow: Watching or unwatching item no longer works (Uncaught exception from Handlebars)
[Regression] Flow: Watching or unwatching item no longer works (Uncaught exce...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-28 19:49 UTC by Krinkle
Modified: 2014-08-29 01:21 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-08-28 19:49:41 UTC 
https://www.mediawiki.org/wiki/Talk:Search is on my watchlist.

1. Click Green star to unwatch.

Expected:
- busy cursor
- ajax request
- icon changes to indicate state is now unwatched
- confirmation message

Actual result
- busy cursor
- (nothing)


Uncaught Error: if doesn't match unless - 2:1 VM143:22
 Handlebars.AST.BlockNode VM143:22
 anonymous VM143:27
 parse VM143:37
 parse VM143:46
 compileInput VM143:54
 ret VM143:54
 FlowHandlebars.processTemplate VM143:71
 FlowHandlebars.processTemplateGetFragment VM143:72
 FlowBoardComponent.UI.events.apiHandlers.watchItem
Comment 1 Krinkle 2014-08-28 20:15:02 UTC 
Looks like watching is broken as well, not just unwatching.
Comment 2 spage 2014-08-28 22:09:46 UTC 
In Firefox I get no feedback but watch succeeds.
If I add ?debug=1 I see "Error: if doesn't match unless - 2:1" in the browser console
Comment 3 Gerrit Notification Bot 2014-08-28 22:29:01 UTC 
Change 156983 had a related patch set uploaded by Bsitu:
template if / unless mismatch

https://gerrit.wikimedia.org/r/156983
Comment 4 Gerrit Notification Bot 2014-08-28 22:50:50 UTC 
Change 156983 merged by jenkins-bot:
Fix client-side watch error

https://gerrit.wikimedia.org/r/156983
Comment 5 Gerrit Notification Bot 2014-08-28 22:56:02 UTC 
Change 156992 had a related patch set uploaded by Spage:
Fix client-side watch error

https://gerrit.wikimedia.org/r/156992
Comment 6 Gerrit Notification Bot 2014-08-28 23:03:44 UTC 
Change 156992 merged by jenkins-bot:
Fix client-side watch error

https://gerrit.wikimedia.org/r/156992
Comment 7 Gerrit Notification Bot 2014-08-28 23:07:07 UTC 
Change 156994 had a related patch set uploaded by Spage:
Update Flow bug 70137 backport

https://gerrit.wikimedia.org/r/156994
Comment 8 Gerrit Notification Bot 2014-08-28 23:24:20 UTC 
Change 156994 merged by MaxSem:
Update Flow bug 70137 backport

https://gerrit.wikimedia.org/r/156994
Comment 9 spage 2014-08-29 01:21:47 UTC 
Fixed, backported to 1.24wmf19 and deployed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links