Last modified: 2014-08-29 08:49:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72161, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70161 - ZeroBanner browser tests does not pass due to X-CS field renaming
ZeroBanner browser tests does not pass due to X-CS field renaming
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
ZeroBanner (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-29 08:19 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-08-29 08:49 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-08-29 08:19:52 UTC 
The browser tests for ZeroBanner pass some X-CS headers to verify free access is provided on the production mobile enwiki.  The job has been failing since day one:

https://integration.wikimedia.org/ci/job/browsertests-ZeroBanner-en.m.wikipedia.org-linux-phantomjs/105/testReport/(root)/

Looking at the feature code, the test still pass X-CS headers when it has been renamed X-CS2.  Low hanging fruit.
Comment 1 Antoine "hashar" Musso (WMF) 2014-08-29 08:21:14 UTC 
+ QA
Comment 2 Gerrit Notification Bot 2014-08-29 08:22:21 UTC 
Change 157047 had a related patch set uploaded by Hashar:
Browser tests: rename X-CS to X-CS2

https://gerrit.wikimedia.org/r/157047
Comment 3 Antoine "hashar" Musso (WMF) 2014-08-29 08:23:57 UTC 
I have filled another bug to get the rest of the code updated: Bug 70162 - ZeroBanner doc still reference X-CS header when it is now X-CS2
Comment 4 Gerrit Notification Bot 2014-08-29 08:46:11 UTC 
Change 157047 abandoned by Hashar:
Browser tests: rename X-CS to X-CS2

Reason:
That change is wrong, the tests pass on my local setup when using X-CS.  Must be some issue with our phantomjs.

https://gerrit.wikimedia.org/r/157047
Comment 5 Antoine "hashar" Musso (WMF) 2014-08-29 08:49:39 UTC 
The test pass on my machine with phantomjs 1.9.7.  Seems to be some problem with our Jenkins job.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links