Last modified: 2014-08-29 18:37:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72167, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70167 - VisualEditor: Applying a link to an invalid title triggers an undo
VisualEditor: Applying a link to an invalid title triggers an undo
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-09-04
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-29 09:59 UTC by Ed Sanders
Modified: 2014-08-29 18:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2014-08-29 09:59:01 UTC
1. Type some text which is an invalid title in MW, e.g. "|InvalidTitle"
2. Select it and hit link
-  Notice that there are no suggestions, and no initial link is applied
3. Type in a valid page name, e.g. "Main page" and press Done
-  Notice some of your text has been deleted (by and undo operation) before the link was applied

The bug is actually in core AnnotationInspector#getTeardownProcess. We call a surface undo() to remove the initial annotation, but in the case of an invalid title there is no initial annotation.
Comment 1 Gerrit Notification Bot 2014-08-29 10:11:43 UTC
Change 157053 had a related patch set uploaded by Esanders:
Only undo if an initial annotation was applied

https://gerrit.wikimedia.org/r/157053
Comment 2 Gerrit Notification Bot 2014-08-29 17:56:22 UTC
Change 157053 merged by jenkins-bot:
Only undo if an initial annotation was applied

https://gerrit.wikimedia.org/r/157053

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links