Last modified: 2014-09-08 15:13:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72193, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70193 - mediawiki_api 0.2.1 attempt to decode Varnish HTML 500 page
mediawiki_api 0.2.1 attempt to decode Varnish HTML 500 page
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Dan Duvall
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-29 20:59 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-08 15:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-08-29 20:59:24 UTC 
Found in browser test build https://integration.wikimedia.org/ci/job/browsertests-Echo-test2.wikipedia.org-linux-chrome-sauce/11/console

Varnish yield a 500 (or 503) error which has a HTML payload.  The response object is passed to json decode which should not happen on a 500.

Trace:

757: unexpected token at '<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
...
</html>' (JSON::ParserError)
gems/json-1.8.1/lib/json/common.rb:155:in `parse'
gems/json-1.8.1/lib/json/common.rb:155:in `parse'
gems/mediawiki_api-0.2.1/lib/mediawiki_api/response.rb:85:in `response_object'
gems/mediawiki_api-0.2.1/lib/mediawiki_api/response.rb:46:in `data'
gems/mediawiki_api-0.2.1/lib/mediawiki_api/client.rb:86:in `log_in'
gems/mediawiki_selenium-0.3.2/lib/mediawiki_selenium/support/pages/api_page.rb:14:in `client'
Echo/tests/browser/features/step_definitions/common_steps.rb:32:in `block in <top (required)>'
Comment 1 Gerrit Notification Bot 2014-08-29 22:37:48 UTC 
Change 157300 had a related patch set uploaded by Dduvall:
Error handling for HTTP 4xx and 5xx responses

https://gerrit.wikimedia.org/r/157300
Comment 2 Gerrit Notification Bot 2014-09-01 18:22:01 UTC 
Change 157300 merged by jenkins-bot:
Error handling for HTTP 4xx and 5xx responses

https://gerrit.wikimedia.org/r/157300
Comment 3 Željko Filipin 2014-09-01 18:35:52 UTC 
Dan, can this bug now be resolved?
Comment 4 Dan Duvall 2014-09-02 18:14:44 UTC 
The fix has been merged. Do we usually wait to mark bugs fixed upon a new release, or is that sufficient?
Comment 5 Chris McMahon 2014-09-02 18:16:31 UTC 
This should do it
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links