Last modified: 2014-09-09 07:28:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72234, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70234 - other projects feature broken with $wgEnableSidebarCache = true
other projects feature broken with $wgEnableSidebarCache = true
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=2 s=2014-08-26
:
Depends on: 70393
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-31 12:53 UTC by Aude
Modified: 2014-09-09 07:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2014-08-31 12:53:28 UTC 
If $wgEnableSidebarCache = true, it seems the other projects feature doesn't work correct.  This is the case on zhwiki.

The sidebar is put into a shared cache for the entire wiki ("zhwiki:sidebar:zh").  Extensions can then use the SidebarBeforeOutput hook to modify both cached and uncached sidebar, but the SkinBuildSidebar (which wikibase uses) is not run for cached sidebar.

For most wmf wikis $wgEnableSidebarCache is set to false, but apparently only for wikis with the Collection extension (most wikis! but not zhwiki and various others) due to problems that extension has with sidebar cache.
Comment 1 Gerrit Notification Bot 2014-08-31 13:31:30 UTC 
Change 157500 had a related patch set uploaded by Aude:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/157500
Comment 2 Gerrit Notification Bot 2014-09-05 12:35:35 UTC 
Change 157500 merged by jenkins-bot:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/157500
Comment 3 Gerrit Notification Bot 2014-09-08 11:13:24 UTC 
Change 159034 had a related patch set uploaded by Aude:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/159034
Comment 4 Gerrit Notification Bot 2014-09-08 14:03:38 UTC 
Change 159034 merged by jenkins-bot:
Don't use SkinBuildSidebar hook for other projects feature

https://gerrit.wikimedia.org/r/159034
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links