Last modified: 2014-09-06 02:57:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72238, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70238 - Link to edit header or create topic fails when non-ASCII in title
Link to edit header or create topic fails when non-ASCII in title
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
Other Linux
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-31 19:08 UTC by Marc A. Pelletier
Modified: 2014-09-06 02:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marc A. Pelletier 2014-08-31 19:08:40 UTC
At least, given a non-standard name for it.

For reference, the project space name contains a non-ASCII character (É) and is set to the project name.

Making the same request but changing the page= parameter to start with "Project_talk:" explicitly works; but the 'true' name fails with invalid-page.

As far as I can tell, the failure happens within secureAndSplit(), but my understanding of the TitleParser is too limited to divine further.
Comment 1 Marc A. Pelletier 2014-08-31 23:13:19 UTC
Extra data point: it would seem that the presence of non-ASCII /anywhere/ in the title makes view-header (at least) fail somewhere in Title::newFromText()
Comment 2 Marc A. Pelletier 2014-08-31 23:47:36 UTC
Aha!  I was looking in the wrong place - the api call *correctly* returns invalid-page because it's the AJAX /call/ that mangles non-ASCII.

In particular, 'É' ends up being encoded as '%25C3%2589' -> the result of uri encoding '%c3%89' -> the proper uri encoded utf8.
Comment 3 Marc A. Pelletier 2014-09-01 00:04:56 UTC
Indeed, commending out the call to encodeURIComponent() at

modules/new/flow-handlebars.js": 699

Solved the immediate problem: it appears that at least under Chrome, window.location.search is already URI-encoded and the extra encoding then mangles the title for api call.
Comment 4 Marc A. Pelletier 2014-09-02 23:58:40 UTC
(Removing the encoreURIComponent() is not a tenable solution is that then breaks different links instead).
Comment 5 Quiddity 2014-09-03 17:28:26 UTC
Added to trello at https://trello.com/c/C9yEQlnr/
Comment 6 spage 2014-09-06 02:57:50 UTC
Marc thanks for the report, we should have paid attention to this before enabling Flow on frwiki and hewiki :-)

A recent fix to the way Flow encodes params to API calls, https://gerrit.wikimedia.org/r/#/c/158549/ , has fixed this bug as well as a bug in clicking on the watch/subscribe star (https://trello.com/c/v2BorMga).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links