Last modified: 2014-09-11 14:27:56 UTC
SemanticForms uses at least $.browser and live multiple times. Those are no longer present without $wgIncludejQueryMigrate = true; I also submitted patch for related issue: https://gerrit.wikimedia.org/r/#/c/157698/
Hi Niklas, I thought the jQuery.browser thing was already resolved in bug 65668. Is SF actually causing Javascript problems? Similarly, I thought all usages of .live() were already removed here: https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FSemanticForms.git/64ed2442f047921238599acc93f1119147cb1f15 Are you sure you're looking at the latest code?
Yaron: $.browser is still used in libs/jquery.fancybox.js. For the rest, I stopped using the outdated Composer version in Ib02cd677a9855a18.
Yes, I know .browser is still being called, but Stephan added code (copied from jquery-migrate.js) that manually defines it if it wasn't defined already. Is it causing JS problems with MW 1.24? (Obviously, a better solution would be to just get rid of the .browser calls, but that's a little tricky because it's 3rd-party code.) It's good to know that at least part of the problem was out-of-date code.
Looks like this was indeed a false alert. You can close this or keep it as reminder to update the development version of SF in composer.
Okay, cool. I'll close the bug, but - what is it that I need to change to fix the Composer problem?
(In reply to Yaron Koren from comment #5) > Okay, cool. I'll close the bug, but - what is it that I need to change to > fix the Composer problem? Update the package https://packagist.org/packages/mediawiki/semantic-forms
Oh, I see - I didn't know anyone was using it. I'm cc-ing Jeroen De Dauw, who is responsible for that package; although it might be better to wait to update it until SF 2.8 comes out, which will hopefully be in the next few days.
I've updated it now. Not needing to fork the repo like this would be great for everyone involved
Okay, great! I'm closing this bug now.
Can you elaborate what can be done to avoid forking?
Add the composer.json file to the main SF repo.
