Last modified: 2014-09-02 17:55:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72280, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70280 - FA and GA icons not showing on language links in MonoBook skin on enwp
FA and GA icons not showing on language links in MonoBook skin on enwp
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-02 08:13 UTC by Spinningspark
Modified: 2014-09-02 17:55 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Spinningspark 2014-09-02 08:13:03 UTC
FA and GA icons are shown next to language links where these articles have that status on the linked wiki.  In Monobook these are not showing, or they are not all showing.  Some examples:

English Wikipeia page https://en.wikipedia.org/wiki/Delian_League
Wikidata page https://www.wikidata.org/wiki/Q193235#sitelinks-wikipedia

The equivalent article is an FA on Hungarian (Magyar) Wikipedia but icon does not show on Monobook skin.

English Wikipedia page https://en.wikipedia.org/wiki/Diamond
Wikidata page https://www.wikidata.org/wiki/Q5283#sitelinks-wikipedia

The equivalent article is an FA on Esperanto, Latvian, and Hungarian Wikipedias, and a GA on German and Estonian Wikipedias.  Only the Esperanto star is showing on Monobooks.

The Aspirin article is another example.  In all cases ths icons are visible when viewed in Vector and seem to be properly marked in Wikidata.
Comment 1 Kunal Mehta (Legoktm) 2014-09-02 10:04:20 UTC
It appears that a rule in enwp's [[MediaWiki:Common.css]] is overriding the badge styling.

/* Portlet bullets */
.portlet li {
    list-style-image: url(//upload.wikimedia.org/wikipedia/en/1/18/Monobook-bullet.png);
}

I'm not sure if we can remove that rule safely...cc'd a few people who might know.
Comment 2 Kunal Mehta (Legoktm) 2014-09-02 10:08:33 UTC
My quick mwgrepping shows that this rule is present on a lot more wikis than just enwp... :|
Comment 3 Bartosz Dziewoński 2014-09-02 11:51:51 UTC
(In reply to Kunal Mehta (Legoktm) from comment #1)
> It appears that a rule in enwp's [[MediaWiki:Common.css]]

[[MediaWiki:Monobook.css]], actually.


It can be safely killed, MonoBook implements these styles itself…
Comment 4 Brad Jorsch 2014-09-02 12:16:50 UTC
(In reply to Kunal Mehta (Legoktm) from comment #1)
> It appears that a rule in enwp's [[MediaWiki:Common.css]] is overriding the
> badge styling.

Based on that, this bug would be INVALID since it's just a problem with on-wiki css rather than anything at all in MediaWiki, or in Wikimedia site configuration.

(In reply to Kunal Mehta (Legoktm) from comment #2)
> My quick mwgrepping shows that this rule is present on a lot more wikis than
> just enwp... :|

Although that means Bugzilla might be useful to coordinate the general cleanup. It wouldn't surprise me if the "lot more wikis" copied it from enwiki.

FWIW, it was added on enwiki in November 2006, https://en.wikipedia.org/w/index.php?diff=prev&oldid=89307273. Unfortunately the edit summaries don't indicate why it was done.
Comment 5 Erwin Dokter 2014-09-02 14:16:38 UTC
Removed the offending (and completely redundant) rule from monobook.css. FA/GA stars/bullets are showing again in Monobook.
Comment 6 Bene* 2014-09-02 17:55:53 UTC
This already got fixed in the WikimediaBadges extension and should show up with the next deployment. See https://github.com/wmde/WikimediaBadges/pull/10

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links