Last modified: 2014-09-10 10:55:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72294, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70294 - Switching options with list-rotators does not work in some cases
Switching options with list-rotators does not work in some cases
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-02 16:03 UTC by tobias.gritschacher
Modified: 2014-09-10 10:55 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2014-09-02 16:03:59 UTC
Mentioned here: https://github.com/wmde/ValueView/pull/109#issuecomment-54130300

Here is a description of the problem for switching the calendar model. But this does not only apply to switching the calendar model, this is also buggy for e.g. switching the precision or in general switching options with the list rotator.

1. Edit a time value.
2. Switch the calendar model by clicking the calendar hint.
3. Cancel editing.
4. Start editing and try to switch the calendar model again by clicking the calendar hint.

Observation: The actual listrotator (advanced adjustments) changes its value but the actual data value is not changed (no parsing is triggered, the preview and the calendar hint are not updated).
There may be a conceptual problem with the lines affected by the actual fix - I added a FIXME there. The reason may be that the ExpertExtender.Listorator object is not affected by the functionality of those lines. Probably, the functionality needs to be implemented in the ExpertExtender.Listorator instead of circumventing it by directly manipulating the listrotator jQuery widget.
Comment 1 WikidataBugzilla 2014-09-03 14:39:13 UTC
Commit pushed to fix-rotator-cancel at https://github.com/wmde/ValueView

https://github.com/wmde/ValueView/commit/7a57c058b046abb09ad4ccc4fc4d7b0a110ee4b7
Fix ListRotator cancel (Bug 70294).
Comment 2 WikidataBugzilla 2014-09-03 15:05:46 UTC
Commit pushed to master at https://github.com/wmde/ValueView

https://github.com/wmde/ValueView/commit/4cee9fc7752059e0910732078a45fe65a5cf13c7
Merge pull request #114 from wmde/fix-rotator-cancel

Fix ListRotator cancel (Bug 70294).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links