Last modified: 2014-09-30 22:17:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72298, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70298 - "Mark all as read" button gone missing
"Mark all as read" button gone missing
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
: 70297 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-02 18:08 UTC by Chris McMahon
Modified: 2014-09-30 22:17 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Mark all as read button gone missing (69.95 KB, image/png)
2014-09-02 18:09 UTC, Chris McMahon
Details

Description Chris McMahon 2014-09-02 18:08:39 UTC
User with messages in Echo flyout should have a "Mark all as read" button, but does not.  See screen shot. 

This is the browser test failure at https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/34/
Comment 1 Chris McMahon 2014-09-02 18:09:26 UTC
Created attachment 16344 [details]
Mark all as read button gone missing
Comment 2 Kunal Mehta (Legoktm) 2014-09-02 19:03:39 UTC
*** Bug 70297 has been marked as a duplicate of this bug. ***
Comment 3 Jon 2014-09-04 16:03:01 UTC

*** This bug has been marked as a duplicate of bug 70329 ***
Comment 4 spage 2014-09-04 17:59:27 UTC
Jon, Bug 70329 - "Message notifications not working" - doesn't sound like this bug, so I'm un-dupe-ing.

I am seeing "Mark all as read" on ee-flow and beta labs when I have notifications from Flow in the Messages pane. Looking at the attached screenshot, Messages(0) means you have zero unread message notifications and they all look gray, so there is indeed no "Mark all as read". 

(The old way "Mark as read" worked is if you had more alerts than the non-scrolling flyout could show, "Mark all as read" would mark all the notifications as read, not just the ones appearing in the flyout.)
Comment 5 Chris McMahon 2014-09-04 18:01:23 UTC
Thanks S, so this is a feature not a bug.
Comment 6 Jon 2014-09-04 18:22:26 UTC
The failure is due to the other bug.
Comment 7 Chris McMahon 2014-09-04 19:38:05 UTC
So it *is* a bug.  :-)

I'll leave the failing test as is for now then.
Comment 9 Jon 2014-09-11 22:50:44 UTC
This is failing for another reason - the default tab was changed and the test was not updated - there needs to be a new step "And I switch to the messages tab"
Comment 10 Gerrit Notification Bot 2014-09-11 22:52:40 UTC
Change 159685 had a related patch set uploaded by Spage:
QA: update Echo messages test

https://gerrit.wikimedia.org/r/159685
Comment 11 Gerrit Notification Bot 2014-09-16 15:08:04 UTC
Change 159685 abandoned by Cmcmahon:
QA: update Echo messages test

Reason:
overtaken by history: https://gerrit.wikimedia.org/r/#/c/160477/

https://gerrit.wikimedia.org/r/159685
Comment 12 Chris McMahon 2014-09-30 20:09:07 UTC

Reopening for regression bug, the "Mark all as read" button is missing again in beta labs, although it functions normally in test2wiki right now. 

https://integration.wikimedia.org/ci/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/92/testReport/junit/(root)/Scenarios%20that%20trigger%20notifications/Mark_all_as_unread/
Comment 13 spage 2014-09-30 21:32:19 UTC
At a quick glance, it seems the 
"And I have a Flow message that triggers an alert notification"

isn't happening. The Echo notification badge count doesn't go to 2, there's no recent message in the messages tab.

For that matter, there's no recent alert in the alerts tab.  Alerts are marked  on view, but I would expect to see something more recent in there than "1 day ago"

It might be delayed notifications: to check see if 'Selenium user firefox' has more recent messages.
Comment 14 Quiddity 2014-09-30 21:39:08 UTC
I'm not getting any Flow Notifications at beta.wmflabs.  I replied to myself and thanked myself (via a testaccount) at http://en.wikipedia.beta.wmflabs.org/wiki/Topic:S3bmb9jyd5l7c34i - I got the Thank notification instantly, but the Flow-reply notifications have not shown up after 1 hour.
Comment 15 spage 2014-09-30 22:17:17 UTC
I filed bug 71484 for the general problem of Flow notifications on beta labs.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links