Last modified: 2014-09-09 18:18:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72312, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70312 - mobile redirect only works on canonical URLs
mobile redirect only works on canonical URLs
Status: RESOLVED WONTFIX
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-02 23:42 UTC by Ryan Kaldari
Modified: 2014-09-09 18:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-09-02 23:42:16 UTC
On a mobile device visit...
https://en.wikipedia.org/w/index.php?title=Cat
...then visit...
https://en.wikipedia.org/wiki/Cat

Expected result: both redirect to mobile view (en.m.wikipedia.org)

Actual result: only the canonical URL redirects to the mobile view

I can only reproduce this bug on the cluster and beta labs. On my local machine, both URLs redirect properly.
Comment 1 Bingle 2014-09-02 23:45:14 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/422pJjh6
Comment 2 Ryan Kaldari 2014-09-02 23:57:58 UTC
This is probably fixed by https://gerrit.wikimedia.org/r/#/c/141576/
Comment 3 Ryan Kaldari 2014-09-03 00:42:50 UTC
Hmm, still seems to be broken on beta labs :(
Comment 4 Ryan Kaldari 2014-09-03 00:48:35 UTC
According to Max this is on purpose. Non-canonical URLs are not redirected by Varnish in order to avoid causing issues with API calls, etc.
Comment 5 Jon 2014-09-03 06:27:28 UTC
Max for completeness can you elaborate? What caching problems might arise?
Comment 6 Max Semenik 2014-09-04 17:07:49 UTC
(In reply to Jon from comment #5)
> Max for completeness can you elaborate? What caching problems might arise?

Where did anyone say anything about caching? :P
It's different kind of problems: you make an API request but suddenly get a redirect, etc.
Comment 7 Ryan Kaldari 2014-09-04 17:27:54 UTC
Could we blacklist API URLs from the redirect rules?
Comment 8 Max Semenik 2014-09-04 22:06:04 UTC
We can. However, index.php and other entry points definitely have their own corner cases, that's why we should only redirect if we're 101% sure it's only a page view.
Comment 9 Ryan Kaldari 2014-09-09 18:18:06 UTC
MaxSem: So you're suggesting that we should only redirect page views and not things like diffs or action=edit, etc.? In that case we should close bug 61489 as WONTFIX and revert the changes that were made to facilitate that.

Another possibility would be to specifically whitelist diff URLs for redirection. What do you think of that idea?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links