Last modified: 2014-11-05 14:41:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72337, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70337 - snakview.variations.Value.draw() does not specify dropValue parameter of jQuery.valueview.stopEditing()
snakview.variations.Value.draw() does not specify dropValue parameter of jQue...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-03 11:50 UTC by Henning
Modified: 2014-11-05 14:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Henning 2014-09-03 11:50:01 UTC
In snakview.variations.Value.draw(), jQuery.valueview's startEditing() or stopEditing() function is called according to whether the ViewState is in edit mode. stopEditing() is always called without a parameter although the dropValue parameter should be specified when editing has been canceled (in contrast to saving). This may not be an urgent problem since the valueview is probably destroyed after canceling anyway. However, this abuse hints wrong code architecture and may cause false assumptions and trigger errors in the future.
Comment 1 Henning 2014-10-30 14:42:44 UTC
https://gerrit.wikimedia.org/r/#/c/170038/
Comment 2 Gerrit Notification Bot 2014-10-31 12:15:53 UTC
Change 170038 had a related patch set uploaded by Tobias Gritschacher:
Added snakview.variations.Value.start/stopEditing()

https://gerrit.wikimedia.org/r/170038
Comment 3 Gerrit Notification Bot 2014-11-05 14:39:58 UTC
Change 170038 merged by jenkins-bot:
Added snakview.variations.Value.start/stopEditing()

https://gerrit.wikimedia.org/r/170038

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links