Last modified: 2014-09-04 15:54:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72347, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70347 - Call to a member function getEntity() on a non-object in EditEntity.php on line 490
Call to a member function getEntity() on a non-object in EditEntity.php on li...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-03 15:33 UTC by Aude
Modified: 2014-09-04 15:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-09-03 15:33:12 UTC
Fatal error: Call to a member function getEntity() on a non-object at /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php on line 490

#0 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(490): Wikibase\EditEntity::fixEditConflict()
#1 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(787): Wikibase\EditEntity->fixEditConflict()
#2 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(685): Wikibase\EditEntity->applyPreSaveChecks()
#3 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ApiWikibase.php(462): Wikibase\EditEntity->attemptSave('/* wbcreateclai...', 2, '64e050852366237...')
#4 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ModifyClaim.php(68): Wikibase\Api\ApiWikibase->attemptSaveEntity(Object(Wikibase\DataModel\Entity\Item), Object(Wikibase\Summary), 2)
#5 /usr/local/apache/common-local/php-1.24wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/CreateClaim.php(78): Wikibase\Api\ModifyClaim->saveChanges(Object(Wikibase\DataModel\Entity\Item), Object(Wikibase\Summary))
#6 /usr/local/apache/common-local/php-1.24wmf19/includes/api/ApiMain.php(929): Wikibase\Api\CreateClaim->execute()
#7 /usr/local/apache/common-local/php-1.24wmf19/includes/api/ApiMain.php(363): ApiMain->executeAction()
#8 /usr/local/apache/common-local/php-1.24wmf19/includes/api/ApiMain.php(334): ApiMain->executeActionWithErrorHandling()
#9 /usr/local/apache/common-local/php-1.24wmf19/api.php(85): ApiMain->execute()
#10 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
Comment 1 Aude 2014-09-03 19:40:01 UTC
I trigger this error when trying to add a label to https://www.wikidata.org/wiki/Q17831325

repored in project chat:

https://www.wikidata.org/wiki/Wikidata:Project_chat#Huh.3F
Comment 2 Aude 2014-09-04 09:37:20 UTC
problem is that this item is missing in the wb_entity_per_page table which is used to find the revision for the item (and check for edit conflict).

we have a maintenance script to repair this inconsistency that we run periodically.  I ran that now and that fixes the problem.

It would definitely be nice to solve the issue why this happens, and if it does, repair in a better way.
Comment 3 Aude 2014-09-04 09:38:08 UTC
reopening, as I think we make the code more robust and handle this situation better.
Comment 4 Aude 2014-09-04 14:52:10 UTC
see bug 70400

and then would also like an exception to be thrown instead of a fatal in EditEntity
Comment 5 Gerrit Notification Bot 2014-09-04 15:09:30 UTC
Change 158389 had a related patch set uploaded by Daniel Kinzler:
Graceful handling of failures to load latest rev

https://gerrit.wikimedia.org/r/158389
Comment 6 Gerrit Notification Bot 2014-09-04 15:51:41 UTC
Change 158389 merged by jenkins-bot:
Graceful handling of failures to load latest rev

https://gerrit.wikimedia.org/r/158389

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links