Last modified: 2014-09-10 21:26:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72358, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70358 - TaskRecommendationImpression.event_offset is set to page offset, not recommendation offset


Summary:	TaskRecommendationImpression.event_offset is set to page offset, not recommen...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GettingStarted (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Sam Smith

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-03 18:06 UTC by Aaron Halfaker
Modified:	2014-09-10 21:26 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Halfaker 2014-09-03 18:06:57 UTC

TaskRecommendationImpression.event_offset is wrong. Corresponds to page number -- not the recommendation offset as spec'd in https://meta.wikimedia.org/wiki/Schema:TaskRecommendationImpression

Steps to reproduce:
0: Go to en.wikipedia.beta.wmflabs.org
1: Log into an account where user_id mod 4 is 2
2: Edit http://en.wikipedia.beta.wmflabs.org/wiki/Microsoft
3: Click "(Lightbulb) Recommendations"
4: Click forward (to view the second page)

The following event is logged:
{
  "event":{
    "setId":"wDan8lyAabJu9wOqztmtYn6g9DETJU9o",
    "userId":4094,
    "pageId":1050,
    "interface":"flyout",
    "offset":1
  },
  "clientValidated":false,
  "revision":-1,
  "schema":"TaskRecommendationImpression",
  "webHost":"en.wikipedia.beta.wmflabs.org",
  "wiki":"enwiki"
}

Note that "offset" is set to 1.  It should be set to 3.

Comment 1 Aaron Halfaker 2014-09-03 18:31:09 UTC

I just realized that revision is set to -1.  Is that the intended behavior?

Comment 2 Matthew Flaschen 2014-09-03 20:03:51 UTC

I think -1 means that the scheme didn't load properly.  It seems to be the default value, which should be overridden by the schema code output by ResourceLoader.

clientValidated is also false, which is another sign of a problem (either in the schema module or in the instrumentation, probably the schema module in this case).

Comment 3 Gerrit Notification Bot 2014-09-05 15:50:43 UTC

Change 158635 had a related patch set uploaded by Phuedx:
Fix TaskRecommendationImpression offset for flyout

https://gerrit.wikimedia.org/r/158635

Comment 4 Sam Smith 2014-09-05 15:52:26 UTC

https://gerrit.wikimedia.org/r/158635 fixes the incorrect offset issue. However, I'm not sure how to proceed with debugging the revision: -1/clientValidated: false issue.

Comment 5 Steven Walling 2014-09-05 19:52:30 UTC

(In reply to Sam Smith from comment #4)
> https://gerrit.wikimedia.org/r/158635 fixes the incorrect offset issue.
> However, I'm not sure how to proceed with debugging the revision:
> -1/clientValidated: false issue.

I split this issue in to bug 70454

Comment 6 Gerrit Notification Bot 2014-09-10 20:54:14 UTC

Change 159551 had a related patch set uploaded by Mattflaschen:
Have flyout depend on required schema, TaskRecommendationImpression

https://gerrit.wikimedia.org/r/159551

Comment 7 Gerrit Notification Bot 2014-09-10 21:22:18 UTC

Change 158635 merged by jenkins-bot:
Fix TaskRecommendationImpression offset for flyout

https://gerrit.wikimedia.org/r/158635

Comment 8 Matthew Flaschen 2014-09-10 21:26:16 UTC

Fixed.

159551 is actually for bug 70454 (I mistagged it).  That is pending review.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links