Last modified: 2014-09-20 19:18:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72371, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70371 - BetaFeatures: Some beta features are incorrectly reporting javascript is need (when it is already enabled)
BetaFeatures: Some beta features are incorrectly reporting javascript is need...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
BetaFeatures (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: James Forrester
:
Depends on: 69823
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-03 23:55 UTC by Jared Zimmerman (WMF)
Modified: 2014-09-20 19:18 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
This feature requires JavaScript. is shown on beta features. (229.40 KB, image/png)
2014-09-03 23:55 UTC, Jared Zimmerman (WMF) 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jared Zimmerman (WMF) 2014-09-03 23:55:41 UTC 
Created attachment 16360 [details]
This feature requires JavaScript. is shown on beta features.

On browsers which have Javascript enabled, some beta features are showing that "This feature requires JavaScript." even when Javascript is enabled. Features seem to work even though the error is shown.
Comment 1 James Forrester 2014-09-08 18:04:35 UTC 
Can't quite work out what's going wrong here, so am putting in a bodge that fixes it at higher cost…
Comment 2 Gerrit Notification Bot 2014-09-08 18:06:42 UTC 
Change 159098 had a related patch set uploaded by Jforrester:
Hide the 'JavaScript needed' warning reliably

https://gerrit.wikimedia.org/r/159098
Comment 3 Matthew Flaschen 2014-09-09 07:03:03 UTC 
That will probably workaround it, but the underlying problem seemed to be bug 69823.
Comment 4 Seb35 2014-09-18 23:25:38 UTC 
This bug is a consequence of bug 69823 (which is itself a consequence of bug 70814), see https://bugzilla.wikimedia.org/show_bug.cgi?id=70814#c5 : the fix there correctly hides the JS warning when JS is enabled. (I make this bug depend of bug 70814, but it is similar to a duplicate.)

Independently of the other bug, I guess this fix is probably worth to be merged also.
Comment 5 Gerrit Notification Bot 2014-09-20 19:18:02 UTC 
Change 159098 abandoned by Bartosz Dziewoński:
Hide the 'JavaScript needed' warning reliably

Reason:
Superseded by https://gerrit.wikimedia.org/r/159538 and https://gerrit.wikimedia.org/r/161690

https://gerrit.wikimedia.org/r/159098
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links