Last modified: 2014-09-18 20:01:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72406, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 70406 - VisualEditor [Regression wmf20] Template dialog no longer displays added template fields' names
VisualEditor [Regression wmf20] Template dialog no longer displays added temp...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal major
: VE-deploy-2014-09-11
Assigned To: Editing team bugs – take if you're interested!
: browser-test-bug
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-04 17:29 UTC by Chris McMahon
Modified: 2014-09-18 20:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Missing template field name (341.34 KB, image/png)
2014-09-04 17:29 UTC, Chris McMahon 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2014-09-04 17:29:02 UTC 
Created attachment 16371 [details]
Missing template field name

On any page e.g. http://en.wikipedia.beta.wmflabs.org/wiki/0.2619265827018721?veaction=edit

Click Insert/Template


Type a name like "New template" and click "Add template"

In the resulting box, type "New template field" or some such. 

Click the "Unknown field" to add the field to the template

Result should show "New template field" but instead is blank.  Note that a "Remove field" icon is in place for the invisible template field. 

See screen shot comparing beta labs with test2wiki.
Comment 1 Alex Monk 2014-09-04 20:28:26 UTC 
Renaming this.$label to something else (e.g. $labelElement) in modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js fixes this
Comment 2 Alex Monk 2014-09-04 20:59:15 UTC 
If you keep it as $label, then add a parameter to a template, then get parameterPage.$label, it appears in place of the outline item widget's label.

Looks like the OOUI element mixin refactor is to blame...
Comment 3 Gerrit Notification Bot 2014-09-04 21:03:53 UTC 
Change 158503 had a related patch set uploaded by Alex Monk:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158503
Comment 4 Gerrit Notification Bot 2014-09-04 21:07:44 UTC 
Change 158503 merged by jenkins-bot:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158503
Comment 5 Gerrit Notification Bot 2014-09-04 21:16:26 UTC 
Change 158508 had a related patch set uploaded by Jforrester:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158508
Comment 6 Gerrit Notification Bot 2014-09-04 21:22:12 UTC 
Change 158508 merged by jenkins-bot:
Rename $label to $labelElement in MWParameterPage to avoid naming conflict

https://gerrit.wikimedia.org/r/158508
Comment 7 Alex Monk 2014-09-04 21:33:36 UTC 
Should be fixed on master.
Comment 8 Chris McMahon 2014-09-04 21:36:42 UTC 
Seems to be working properly in beta labs now
Comment 9 Rummana Yasmeen 2014-09-05 19:13:42 UTC 
Yes, working properly in Betalabs and test2
Comment 10 Rummana Yasmeen 2014-09-18 20:01:30 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links