Last modified: 2014-09-12 17:21:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72423, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70423 - OOjs UI: [Regression wmf20] Popups sizing broken
OOjs UI: [Regression wmf20] Popups sizing broken
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Alex Monk
:
: 70604 (view as bug list)
Depends on:
Blocks: 70565
  Show dependency treegraph
 
Reported: 2014-09-04 23:34 UTC by Rummana Yasmeen
Modified: 2014-09-12 17:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (124.49 KB, image/png)
2014-09-04 23:34 UTC, Rummana Yasmeen
Details
betalabs screenshot (158.49 KB, image/png)
2014-09-04 23:36 UTC, Rummana Yasmeen
Details
Attempting to create a page on mediawiki.org (70.74 KB, image/png)
2014-09-09 08:32 UTC, Elitre
Details
screenshot of tooltip dialogs (52.29 KB, image/png)
2014-09-09 18:23 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-09-04 23:34:24 UTC
Created attachment 16378 [details]
Screenshot

Open a new page with VE for the first time which has not yet been created.
Observe the notification dialog box.

See the screenshot attached
Comment 1 Rummana Yasmeen 2014-09-04 23:36:37 UTC
Created attachment 16379 [details]
betalabs screenshot
Comment 2 Alex Monk 2014-09-08 03:52:53 UTC
Seems to have been caused by Gerrit change #157295

In particular, this bit:

"Bonus:
ClippableElement.js
* The toggleClipping method had an undocumented and unneeded async
  behavior for calling clip the first time after toggling clipping
** This has been removed and calling code has been verified to not be
   affected
** A comment has been added to inform callers that the element needs to
   be attached and visible before toggling clipping, which is supposedly
   what the setTimeout was in aid of, but no longer seems to be needed
   for"
Comment 3 Gerrit Notification Bot 2014-09-08 15:11:43 UTC
Change 159062 had a related patch set uploaded by Alex Monk:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159062
Comment 4 James Forrester 2014-09-08 17:42:55 UTC
*** Bug 70565 has been marked as a duplicate of this bug. ***
Comment 5 Elitre 2014-09-09 08:31:43 UTC
Adding my screenshot taken in IE.
Comment 6 Elitre 2014-09-09 08:32:33 UTC
Created attachment 16411 [details]
Attempting to create a page on mediawiki.org
Comment 7 Rummana Yasmeen 2014-09-09 18:23:01 UTC
Created attachment 16417 [details]
screenshot of tooltip dialogs

There are few other places where notification dialogs are appearing in not so properly styled way.For example: the help tooltip dialogs inside Page Settings option or Template dialog. If they dont get fixed by this patch , I will file a separate bug.For now, keeping it all in this one, to keep track.
Comment 8 Alex Monk 2014-09-10 13:36:28 UTC
*** Bug 70604 has been marked as a duplicate of this bug. ***
Comment 9 Gerrit Notification Bot 2014-09-10 17:13:29 UTC
Change 159062 merged by jenkins-bot:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159062
Comment 10 Gerrit Notification Bot 2014-09-10 18:06:54 UTC
Change 159508 had a related patch set uploaded by Catrope:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159508
Comment 11 Gerrit Notification Bot 2014-09-10 18:09:00 UTC
Change 159508 merged by Catrope:
PopupWidget: Toggle clipping -after- updating dimensions

https://gerrit.wikimedia.org/r/159508
Comment 12 Rummana Yasmeen 2014-09-10 19:10:49 UTC
verified the fix in Betalabs,separate bug has been filed for the help tooltips for Page Settings menu.
Comment 13 Rummana Yasmeen 2014-09-11 04:29:52 UTC
Backport did not work in test2 , the notification dialog and the context dialogs for template fields are still broken there.
Comment 14 Alex Monk 2014-09-11 12:06:07 UTC
It's working for me... Can you try it without any caching, etc.? Maybe in incognito mode?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links