Last modified: 2014-11-04 06:13:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72443, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70443 - [l10n] Use Scap in Localisation Update
[l10n] Use Scap in Localisation Update
Status: PATCH_TO_REVIEW
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on: 70446
Blocks: 70752
  Show dependency treegraph
 
Reported: 2014-09-05 14:12 UTC by Sam Reed (reedy)
Modified: 2014-11-04 06:13 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-09-05 14:12:19 UTC
Currently, it just iterates over the lot, it'd be nice (for l10nupdate usages) if we could pass a parameter to scap-rebuild-cdbs of the mediawiki version to rebuild

        # Rebuild the CDB files from the JSON versions
        for version, wikidb in self.active_wikiversions().items():
            cache_dir = os.path.join(self.config['deploy_dir'],
                'php-%s' % version, 'cache', 'l10n')
            tasks.merge_cdb_updates(
                cache_dir, use_cores, True, self.arguments.mute)
Comment 1 Sam Reed (reedy) 2014-09-05 14:14:09 UTC
As a no-op for a version, it's still a tonne quicker than the current method (see https://gerrit.wikimedia.org/r/#/c/158623 for improvements), so running the extra iterations isn't the biggest issue.



On second thought, is this worth doing? Should I just rework the script so that it does the 3 rebuilds, syncs, and then does just one call to rebuild the cdbs?
Comment 2 Sam Reed (reedy) 2014-09-05 14:18:57 UTC
https://github.com/wikimedia/operations-puppet/blob/production/files/misc/l10nupdate/l10nupdate-1#L68-L111


That block could nearly just be replaced with a scap call, couldn't it?

The only real difference is the LocalisationUpdate call out (at a quick glance, scap doesn't do anything with LU currently) https://github.com/wikimedia/operations-puppet/blob/production/files/misc/l10nupdate/l10nupdate-1#L87-L89

The updating of the source repos needs to be done first (so that can stay for now), and then the refresh of the RL cache needs doing after...
Comment 3 Gerrit Notification Bot 2014-09-22 21:43:54 UTC
Change 158623 had a related patch set uploaded by Greg Grossmeier:
Use sync-dir to copy out l10n json files, build cdbs on hosts

https://gerrit.wikimedia.org/r/158623
Comment 4 Gerrit Notification Bot 2014-11-04 06:13:06 UTC
Change 158623 merged by Springle:
Use sync-dir to copy out l10n json files, build cdbs on hosts

https://gerrit.wikimedia.org/r/158623

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links