Last modified: 2014-09-29 15:00:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72495, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70495 - TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent


Summary:	TemplateSandbox doesn't handle things like #ifexist and Scribunto's getContent

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TemplateSandbox (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Jackmcbarn

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-09-06 15:59 UTC by Jackmcbarn
Modified:	2014-09-29 15:00 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jackmcbarn 2014-09-06 15:59:30 UTC

When previewing a page with TemplateSandbox, if getContent() is called on the page in question, it will incorrectly return the stored content rather than the content provided by TemplateSandbox.

Comment 1 Jackmcbarn 2014-09-15 02:50:52 UTC

Changing to a TemplateSandbox bug, since this affects other things too, like #ifexist. The problem is that there's a lot of ways that one page can interact with another, and the only one TemplateSandbox catches is transclusion.

Comment 2 Gerrit Notification Bot 2014-09-15 22:46:54 UTC

Change 160546 had a related patch set uploaded by Jackmcbarn:
Add TitleExists hook

https://gerrit.wikimedia.org/r/160546

Comment 3 Gerrit Notification Bot 2014-09-15 22:47:58 UTC

Change 160549 had a related patch set uploaded by Jackmcbarn:
Call Title::exists() instead of checking the ID

https://gerrit.wikimedia.org/r/160549

Comment 4 Gerrit Notification Bot 2014-09-15 22:48:41 UTC

Change 160550 had a related patch set uploaded by Jackmcbarn:
Call Title::exists() instead of checking the ID

https://gerrit.wikimedia.org/r/160550

Comment 5 Gerrit Notification Bot 2014-09-15 23:11:40 UTC

Change 160555 had a related patch set uploaded by Jackmcbarn:
Hook TitleExists when previewing

https://gerrit.wikimedia.org/r/160555

Comment 6 Jackmcbarn 2014-09-15 23:13:51 UTC

The exists problem and the getContent problem turn out to have totally separate fixes. The above 4 patches fix the exists problem; the next set of patches will fix the getContent problem.

Comment 7 Gerrit Notification Bot 2014-09-16 00:09:07 UTC

Change 160570 had a related patch set uploaded by Jackmcbarn:
Add RevisionFromTitle hook

https://gerrit.wikimedia.org/r/160570

Comment 8 Gerrit Notification Bot 2014-09-16 00:17:18 UTC

Change 160572 had a related patch set uploaded by Jackmcbarn:
Use RevisionFromTitle instead of a template callback

https://gerrit.wikimedia.org/r/160572

Comment 9 Jackmcbarn 2014-09-16 00:17:46 UTC

All of the patches needed to fix this are now uploaded.

Comment 10 Gerrit Notification Bot 2014-09-17 17:00:42 UTC

Change 160549 merged by jenkins-bot:
Call Title::exists() instead of checking the ID

https://gerrit.wikimedia.org/r/160549

Comment 11 Gerrit Notification Bot 2014-09-17 17:11:33 UTC

Change 160546 merged by jenkins-bot:
Add TitleExists hook

https://gerrit.wikimedia.org/r/160546

Comment 12 Gerrit Notification Bot 2014-09-18 17:48:04 UTC

Change 160555 merged by jenkins-bot:
Hook TitleExists when previewing

https://gerrit.wikimedia.org/r/160555

Comment 13 Gerrit Notification Bot 2014-09-25 22:52:13 UTC

Change 160570 merged by jenkins-bot:
Add parser callback to get a page's current revision

https://gerrit.wikimedia.org/r/160570

Comment 14 Gerrit Notification Bot 2014-09-29 14:57:35 UTC

Change 160550 merged by jenkins-bot:
Improve compatibility with TemplateSandbox

https://gerrit.wikimedia.org/r/160550

Comment 15 Gerrit Notification Bot 2014-09-29 14:57:39 UTC

Change 160572 merged by jenkins-bot:
Use current revision callback instead of template callback

https://gerrit.wikimedia.org/r/160572

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links