Last modified: 2014-11-03 19:09:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72497, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 70497 - Flow: Deleted content when viewed by non-admins leads to fatal permissionexception message
Flow: Deleted content when viewed by non-admins leads to fatal permissionexce...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 70598 70692 71244 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-06 20:03 UTC by Quiddity
Modified: 2014-11-03 19:09 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2014-09-06 20:03:34 UTC
If a non-admin visits https://en.wikipedia.org/w/index.php?title=Topic:S1u4yp09cwg7ku3l (a deleted topic)
they receive this error message:

 Insufficient permission to access the content.
 Return to Main Page.
 [6138f9cc] 2014-09-06 19:39:49: Fatal exception of type Flow\Exception\PermissionException

There should be a more informative message for readers, so that they can understand what happened. The standard is a message like this: https://en.wikipedia.org/w/index.php?title=Talk:Gabriel_de_Saint_Nicholas&redirect=no
Comment 1 Quiddity 2014-09-06 20:05:11 UTC
On trello at https://trello.com/c/QaqSXXyF/
Comment 2 Bartosz Dziewoński 2014-09-09 15:05:50 UTC
*** Bug 70598 has been marked as a duplicate of this bug. ***
Comment 3 Quiddity 2014-09-11 03:35:40 UTC
Copying comment from 70598:

(Marius Hoch wrote)
> Trace:
> 
> 2014-09-09 11:08:15 mw1052 mediawikiwiki: [e4cd902c]
> /w/index.php?title=Topic:S1no6gacx8ayjfuo&workflow=s1no6gacx8ayjfuo  
> Exception from line 438 of
> /usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/Block/
> Topic.php: Not Allowed
> #0
> /usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/View.
> php(129): Flow\Block\TopicBlock->renderAPI(Object(Flow\Templating), Array)
> #1
> /usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/
> Actions/Action.php(88): Flow\View->show(Object(Flow\WorkflowLoader), 'view')
> #2
> /usr/local/apache/common-local/php-1.24wmf20/extensions/Flow/includes/
> Actions/Action.php(35): Flow\Actions\FlowAction->showForAction('view')
> #3 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(414):
> Flow\Actions\FlowAction->show()
> #4 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(282):
> MediaWiki->performAction(Object(Article), Object(Title))
> #5 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(584):
> MediaWiki->performRequest()
> #6 /usr/local/apache/common-local/php-1.24wmf20/includes/MediaWiki.php(435):
> MediaWiki->main()
> #7 /usr/local/apache/common-local/php-1.24wmf20/index.php(46):
> MediaWiki->run()
> #8 /usr/local/apache/common-local/w/index.php(3):
> require('/usr/local/apac...')




Copying comment from 70692:

(Daniel Zahn wrote)
> on a https://en.wikipedia.org/wiki/Topic:S23kgr0jal6zroqo 
> 
> i get this:
> 
> ---<snip>---
> 
> Error
> 
> Insufficient permission to access the content.
> 
> Return to Main Page.
> [d9c5180c] 2014-09-10 23:06:33: Fatal exception of type
> Flow\Exception\PermissionException
> 
> ---</snip>---
> 
> it's not about the "insufficient permission" part, that is legit,
> but the fatal exception that comes with it.
Comment 4 Quiddity 2014-09-11 03:36:01 UTC
*** Bug 70692 has been marked as a duplicate of this bug. ***
Comment 5 Quiddity 2014-09-25 01:37:26 UTC
*** Bug 71244 has been marked as a duplicate of this bug. ***
Comment 6 Helder 2014-09-26 20:16:54 UTC
I assume this is the same problem:
https://www.mediawiki.org/w/index.php?title=Topic:S2tc6rvtyh4qlwcs&workflow=s2tc6rvtyh4qlwcs
[95d66b59] 2014-09-26 20:15:15: Fatal exception of type Flow\Exception\PermissionException
Comment 7 Gerrit Notification Bot 2014-10-14 14:40:06 UTC
Change 166574 had a related patch set uploaded by Matthias Mullie:
(bug 70497) Don't throw exception; show nicer error message for insufficient permissions

https://gerrit.wikimedia.org/r/166574
Comment 8 Gerrit Notification Bot 2014-10-14 14:40:13 UTC
Change 166575 had a related patch set uploaded by Matthias Mullie:
(bug 70497) Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575
Comment 9 Gerrit Notification Bot 2014-10-24 02:13:24 UTC
Change 166574 merged by jenkins-bot:
(bug 70497) Don't throw exception; show nicer error message for insufficient permissions

https://gerrit.wikimedia.org/r/166574
Comment 10 Gerrit Notification Bot 2014-10-24 22:57:52 UTC
Change 166575 had a related patch set uploaded by Siebrand:
Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575
Comment 11 Gerrit Notification Bot 2014-11-03 18:31:23 UTC
Change 166575 merged by jenkins-bot:
Show more descriptive error message for insufficient permissions

https://gerrit.wikimedia.org/r/166575

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links